User Details
- User Since
- Jan 13 2018, 10:50 PM (327 w, 2 d)
- Availability
- Available
Jun 10 2020
Code looks good to me - but I've not tested this change.
May 25 2020
Aug 26 2019
I'm fine with dropping it as it is dead code. Please add a note to the ticket with the commit # after merging this: https://bugs.kde.org/show_bug.cgi?id=149482
Apr 8 2019
Thanks for your work!
Mar 30 2019
Thanks. Looks good to me. Have you tested with all available color depths?
I cannot comment on this - code looks nice, but I do not know the 'va_list' thing. Can somebody else who know this review please?
Feb 10 2019
LGTM. Thanks.
Jul 4 2018
Jun 25 2018
Thanks, this looks like a nice feature addition to KRDC! I have not tested it - but code looks good.
Jan 20 2018
BTW, I really don't know how to handle the RDpassword. I would like to store that into KWallet, but that is an 'host preference' for KRDC and the kwallet isn't accessible from that class. Should I implement it that way?
Jan 17 2018
Minor points I have noticed on screenshots:
Jan 13 2018
Thanks for your work! Code looks good after a first short look into it. Can you share a screenshot how it looks with the new tab widget?