uwolfer (Urs Wolfer)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jan 13 2018, 10:50 PM (327 w, 2 d)
Availability
Available

Recent Activity

Jun 10 2020

uwolfer accepted D29822: Signal the main window about vnc disconnection.

Code looks good to me - but I've not tested this change.

Jun 10 2020, 7:22 PM

May 25 2020

uwolfer added inline comments to D29822: Signal the main window about vnc disconnection.
May 25 2020, 6:09 PM

Aug 26 2019

uwolfer accepted D23453: Remove NX support.

I'm fine with dropping it as it is dead code. Please add a note to the ticket with the commit # after merging this: https://bugs.kde.org/show_bug.cgi?id=149482

Aug 26 2019, 5:46 PM

Apr 8 2019

uwolfer accepted D20123: Do not assume framebuffer and scalines are always 32-bit aligned.

Thanks for your work!

Apr 8 2019, 3:07 PM

Mar 30 2019

uwolfer added a comment to D20123: Do not assume framebuffer and scalines are always 32-bit aligned.

Thanks. Looks good to me. Have you tested with all available color depths?

Mar 30 2019, 6:37 PM
uwolfer resigned from D20118: Pass va_list as such, instead of passing to variadic function.

I cannot comment on this - code looks nice, but I do not know the 'va_list' thing. Can somebody else who know this review please?

Mar 30 2019, 10:51 AM

Feb 10 2019

uwolfer accepted D17327: KRDC: add default shortcut to open new connection.

LGTM. Thanks.

Feb 10 2019, 10:21 AM

Jul 4 2018

uwolfer accepted D13659: Add option of connecting to the vnc server through a ssh tunnel.
Jul 4 2018, 6:59 PM

Jun 25 2018

uwolfer added a comment to D13659: Add option of connecting to the vnc server through a ssh tunnel.

Thanks, this looks like a nice feature addition to KRDC! I have not tested it - but code looks good.

Jun 25 2018, 2:34 PM

Jan 20 2018

uwolfer added a comment to D9854: WIP: Support for Remote Desktop Gateway.

BTW, I really don't know how to handle the RDpassword. I would like to store that into KWallet, but that is an 'host preference' for KRDC and the kwallet isn't accessible from that class. Should I implement it that way?

Jan 20 2018, 4:51 PM

Jan 17 2018

uwolfer added a comment to D9854: WIP: Support for Remote Desktop Gateway.

Minor points I have noticed on screenshots:

Jan 17 2018, 7:33 PM

Jan 13 2018

uwolfer added a comment to D9854: WIP: Support for Remote Desktop Gateway.

Thanks for your work! Code looks good after a first short look into it. Can you share a screenshot how it looks with the new tab widget?

Jan 13 2018, 10:54 PM