Differential D29191

[FileWatch] Fix watch updates on config changes
ClosedPublic
Actions

Authored by bruns on Apr 25 2020, 9:14 PM.

Details

Reviewers
ngraham
meven
Group Reviewers
Baloo
Commits
R293:c76397081d1e: [FileWatch] Fix watch updates on config changes
Summary

Track the current list of include/exclude folders, and on a config change
add/remove watches for the differences. Previously, when an include
folder was removed the corresponding watches were never removed.

Depends on D29190, D29189

Test Plan

ctest -R filewatchtest

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Apr 25 2020, 9:14 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptApr 25 2020, 9:14 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Apr 25 2020, 9:14 PM
meven accepted this revision.Apr 26 2020, 11:43 AM
meven added a subscriber: meven.

Good to me

This revision is now accepted and ready to land.Apr 26 2020, 11:43 AM
Closed by commit R293:c76397081d1e: [FileWatch] Fix watch updates on config changes (authored by bruns). · Explain WhyApr 26 2020, 2:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 81243

View Options

autotests/unit/file/filewatchtest.cpp

Loading...
View Options

src/file/filewatch.h

Loading...
View Options

src/file/filewatch.cpp

Loading...