file extractor: fix linking
AbandonedPublic

Authored by eszlari on May 10 2020, 1:07 PM.

Details

Reviewers
bruns
Summary
[291/397] Linking CXX executable bin/baloo_file_extractor
FAILED: bin/baloo_file_extractor 
: && /usr/bin/c++  -O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-operator-names -fno-exceptions -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -Wvla -Wdate-time -Wsuggest-override -Wlogical-op -fdiagnostics-color=always -pedantic -Wzero-as-null-pointer-constant  -Wl,--enable-new-dtags -L/app/lib -Wl,-z,relro,-z,now -Wl,--as-needed src/file/extractor/CMakeFiles/baloo_file_extractor.dir/baloo_file_extractor_autogen/mocs_compilation.cpp.o src/file/extractor/CMakeFiles/baloo_file_extractor.dir/main.cpp.o src/file/extractor/CMakeFiles/baloo_file_extractor.dir/app.cpp.o src/file/extractor/CMakeFiles/baloo_file_extractor.dir/result.cpp.o src/file/extractor/CMakeFiles/baloo_file_extractor.dir/idlestatemonitor.cpp.o src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/priority.cpp.o src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/basicindexingjob.cpp.o src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/fileindexerconfig.cpp.o src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/storagedevices.cpp.o src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/regexpcache.cpp.o src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/fileexcludefilters.cpp.o src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/propertydata.cpp.o src/file/extractor/CMakeFiles/baloo_file_extractor.dir/baloodebug.cpp.o src/file/extractor/CMakeFiles/baloo_file_extractor.dir/baloosettings.cpp.o  -o bin/baloo_file_extractor  -Wl,-rpath,/run/build/baloo/bin: /app/lib/libKF5FileMetaData.so.5.69.0 /usr/lib/x86_64-linux-gnu/libKF5ConfigCore.so.5.69.0 /usr/lib/x86_64-linux-gnu/libKF5Solid.so.5.69.0 bin/libKF5BalooEngine.so.5.69.0 /usr/lib/x86_64-linux-gnu/libKF5Crash.so.5.69.0 /usr/lib/x86_64-linux-gnu/libKF5IdleTime.so.5.69.0 /usr/lib/x86_64-linux-gnu/libQt5DBus.so.5.14.2 /usr/lib/x86_64-linux-gnu/libKF5I18n.so.5.69.0 -llmdb /usr/lib/x86_64-linux-gnu/libKF5CoreAddons.so.5.69.0 /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.14.2 /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5.14.2 /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.14.2 && :
/usr/lib/gcc/x86_64-unknown-linux-gnu/9.2.0/../../../../x86_64-unknown-linux-gnu/bin/ld: src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/fileindexerconfig.cpp.o: in function `BalooSettings::setDbVersion(int)':
/run/build/baloo/src/file/baloosettings.h:105: undefined reference to `BalooSettings::dbVersionChanged()'
/usr/lib/gcc/x86_64-unknown-linux-gnu/9.2.0/../../../../x86_64-unknown-linux-gnu/bin/ld: src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/fileindexerconfig.cpp.o: in function `BalooSettings::setExcludedFilters(QStringList const&)':
/run/build/baloo/src/file/baloosettings.h:327: undefined reference to `BalooSettings::excludedFiltersChanged()'
/usr/lib/gcc/x86_64-unknown-linux-gnu/9.2.0/../../../../x86_64-unknown-linux-gnu/bin/ld: src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/fileindexerconfig.cpp.o: in function `BalooSettings::setExcludedFiltersVersion(int)':
/run/build/baloo/src/file/baloosettings.h:364: undefined reference to `BalooSettings::excludedFiltersVersionChanged()'
collect2: error: ld returned 1 exit status

https://flathub.org/builds/#/builders/32/builds/18929

Diff Detail

Repository
R293 Baloo
Lint
Lint Skipped
Unit
Unit Tests Skipped
eszlari created this revision.May 10 2020, 1:07 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptMay 10 2020, 1:07 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
eszlari requested review of this revision.May 10 2020, 1:07 PM
bruns requested changes to this revision.May 10 2020, 4:19 PM
bruns added a subscriber: bruns.

Your build system seems to be broken. The "missing" methods are statically linked, see src/file/extractor/CMakeFiles/baloo_file_extractor.dir/baloosettings.cpp.o

This revision now requires changes to proceed.May 10 2020, 4:19 PM

Indeed. It failed with cmake 3.15.2 + ninja 1.9.0 and worked with make (4.2.1).

eszlari abandoned this revision.May 10 2020, 6:25 PM

Strange. It worked with gmake locally, but failed on the Flathub buildbot again (https://flathub.org/builds/#/builders/32/builds/19809, only x86_64 failed, not arm or aarch64).

What really fixed it at the end, was switching to an out of source build.