Differential D29181

Use KFileMetaData for XAttr support instead of private reimplementation
ClosedPublic
Actions

Authored by bruns on Apr 25 2020, 5:22 PM.

Details

Reviewers
ngraham
apol
Group Reviewers
Baloo
Commits
R293:774bd228b749: Use KFileMetaData for XAttr support instead of private reimplementation
Summary

This removes a lot of duplicate code, and on top it actually works
as it no longer hardcodes a number of locations (e.g. /tmp/ was always
blacklisted).

Test Plan

ctest

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Apr 25 2020, 5:22 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptApr 25 2020, 5:22 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Apr 25 2020, 5:22 PM
apol accepted this revision.Apr 25 2020, 5:54 PM
This revision is now accepted and ready to land.Apr 25 2020, 5:54 PM
Closed by commit R293:774bd228b749: Use KFileMetaData for XAttr support instead of private reimplementation (authored by bruns). · Explain WhyApr 25 2020, 7:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 81192

View Options

autotests/unit/file/CMakeLists.txt

Loading...
View Options

autotests/unit/file/filewatchtest.cpp

Loading...
View Options

autotests/unit/lib/baloo_xattr_p.h

Loading...
View Options

autotests/unit/lib/xattrdetector.h

Loading...
View Options

autotests/unit/lib/xattrdetector.cpp

Loading...