Differential D29190

[FileWatchTest] Extend coverage to config updates
ClosedPublic
Actions

Authored by bruns on Apr 25 2020, 9:12 PM.

Details

Reviewers
ngraham
meven
Group Reviewers
Baloo
Commits
R293:1a3c23f076d2: [FileWatchTest] Extend coverage to config updates
Summary

Currently, config changes are not covered in the
tests, add a test case

Test Plan

ctest -R filewatchtest

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Apr 25 2020, 9:12 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptApr 25 2020, 9:12 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Apr 25 2020, 9:12 PM
bruns updated this revision to Diff 81207.Apr 25 2020, 9:16 PM

whitespace

meven added a subscriber: meven.Apr 26 2020, 11:39 AM
meven added inline comments.
autotests/unit/file/filewatchtest.cpp
165

Could you add a comment "d11, d21 are marked as excluded"

meven accepted this revision.Apr 26 2020, 11:40 AM
meven added inline comments.
autotests/unit/file/filewatchtest.cpp
223

Maybe less, to keep the test reasonably fast.

This revision is now accepted and ready to land.Apr 26 2020, 11:40 AM
bruns marked an inline comment as done.Apr 26 2020, 12:31 PM
bruns added inline comments.
autotests/unit/file/filewatchtest.cpp
223

Does not really matter as soon as the code is fixed (review pending). Default would be 5000.

bruns marked an inline comment as done.Apr 26 2020, 12:31 PM
Closed by commit R293:1a3c23f076d2: [FileWatchTest] Extend coverage to config updates (authored by bruns). · Explain WhyApr 26 2020, 12:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 81229

View Options

autotests/unit/file/filewatchtest.cpp

Loading...