[Indexers] Ignore name-based mimetype for initial indexing decisions
ClosedPublic

Authored by bruns on Apr 26 2020, 3:08 PM.

Details

Reviewers
ngraham
Group Reviewers
Baloo
Summary

The name based mime type is inaccurate, so it should not be used to
decide if a file should be indexed. In case a specific extension should
be skipped this can still be done accurately by the name based filters,
e.g. instead of "image/png" "*.png" can be used, or the whole directory
can be excluded.

This inaccuracy is also confusing for the user, as a file without
extension will be added to the index, but adding an extension removes
the file from the index. The file extension may also be ambiguous.

This also matches the current list of excluded mime types, which are
source files for various languages. These blow up the full text index
and thus should be excluded (by default), but just adding the file names
increases the index size only marginally.

The 'inability' to find files is a recurring user complaint.

CCBUG: 422085

Depends on D28932

Diff Detail

Repository
R293 Baloo
Branch
submit
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25933
Build 25951: arc lint + arc unit
bruns created this revision.Apr 26 2020, 3:08 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptApr 26 2020, 3:08 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Apr 26 2020, 3:08 PM
bruns edited the summary of this revision. (Show Details)Jun 10 2020, 10:15 PM
ngraham accepted this revision.Jun 10 2020, 10:33 PM

Shipit!

This revision is now accepted and ready to land.Jun 10 2020, 10:33 PM
bruns closed this revision.Jun 10 2020, 11:16 PM