Merge request sent: https://invent.kde.org/network/ktorrent/-/merge_requests/3

Could you please clarify a process? Shall I pass the review on phabricator then create a pull request on Invent? Or just create a Pull Request on Invent?

Commited: https://invent.kde.org/network/libktorrent/-/commit/7dab629a2f79ecea4bee734e87b3ac747eedc3e5

Commited with https://invent.kde.org/network/libktorrent/-/commit/f12628ccfc153129548185c92fd7b02574b38e44

Hmm... I forget to fix indentation.
It's quite annoying that KTorrent and Libktorrent projects both have different styles of indentation: tabs and spaces.

Pushed to master:
https://invent.kde.org/network/ktorrent/-/commit/d4ec62aeb4a941a18322856a2e6d8ca73846306b

I've asked Bart Clephas to forward his PR in SkanLite's github project to the phabricator, so added myself as secondary reviewer to follow it.
But Kåre Särs is a decision maker here.

Once I faced with this bug on Kubuntu 19.10 but couldn't reproduce. And I still can't reproduce it. Anyway change looks fine for me. Let's rely on stikonas opinion

Is this still actual or should be closed as completed?

any news on this?

Hmm, I've just git grep the repo and found another place that is most probably affected by the same problem in FTP slave;
https://github.com/KDE/kio/blob/d03551cd0367ac7760224c56bda943c937ba5dac/src/ioslaves/ftp/ftp.cpp#L320

I thought this review should be autoclosed but it seems i misspelled something in commit's description.
Anyway, the changes are pushed: https://github.com/KDE/ktorrent/commit/4347981f3c2d1f1aa71c338d54807e627dea3950

I've just tried this with version 5.1.2. The app has crashed. So problem is still exists. Perhaps would be better to apply this patch?

In D20696#453545, @stikonas wrote:

If I commit this myself, I need your mail address for git commit --author. Is it the same as in reviewboard (I can't see the one from Phabricator)?

I've checked that diff works after recent updates to the codebase and replaced QTabWidget with QTabBar.
Now ready for review whenever you have a free time for this.

I've changed setting's text to "Display resulting image while scanning"

Now without QScopedPointer

Kåre, could you comment my reply?: https://phabricator.kde.org/D18966#411134

oops, made a copy-paste mistake. Updated again

updated

Ok, in this case this we need to patch 2 projects and this review will contain only a minimal changes.

Ok, now with renamed var.

I've just realized that I forgot to add implementation of a new static func for TWAIN libksane version (ktwain_widget.cpp) AGAIN.
TWAIN ver is build for Windows only and mostly consists of stubs. Last time I forget about it it caused a lib compilation failure during CI autotests and I was traced by admin to fix this.
Luckily the patch wasn't commited yet.

updated

Now with saveQImage() splitted into saveQImage() and save16BitPng().
And more correct processing of 16bit m_img saving if it's non empty and was already converted inside Skanlite::imageReady bcs of showB4Save->isChecked()

Sorry, I missed your reply and realized that only now.
I've already forget the code and probably bcs of that didn't get your comment.

Ping!

One more update, all notes should be addressed in this except for passing fileUrl

Update to a QThread-based approach of image saving. Now it uses static KSaneWidget::toQImageSilent(). Thus this requires https://phabricator.kde.org/D18446 to be applied.
As it's static it can't emit signals and thus KSaneImageSaver is now getting pointer to KSaneWidget to emit it's signal in case of problems.
Also KSaneImageSaver is now a member of Skanlite class and it's lambda is replaced with new Skanlite's slot.

In D17955#393880, @sars wrote:

@sars could you take a look on thread based version (latest diff)?

How about this async approach? I'm still testing. So far it's ok.

replaced path() with toLocalFIle()

In D17955#388887, @sars wrote:

But this all is to just re-paint one time before we freeze for the time it takes to save of the file? Would it be better in the long run to think about moving the saving to a thread?

It seems there are 2 kind of widgets in KSaneWidget that don't repaint if you call KSaneWidget::repaint()
One is QGraphicsView-derived KSaneViewer, bcs it needs viewport()->repaint() instead.
Another are two QScrollAreas in 2 tabs for basic and other options. They need widget()->repaint() instead.

replace qApp->processEvents() with