Port KTorrent to QWebEngine
ClosedPublic
Actions

Authored by gassaf on Nov 15 2019, 1:55 AM.

Details

Reviewers

stikonas
trufanov
mlaurent

Maniphest Tasks

T11609: Port KTorrent away from WebKit

Commits

R473:f5a1958ebdca: Port KTorrent to QWebEngine

Summary

Ports KTorrent Search Plugin to QWebEngine
Ports KTorrent Syndication Plugin to QWebEngine

Test Plan

Use search Plugin:

Search for torrent
Start download automatically from magnet link
Start download automatically from torrent file
Save torrent file to disk

Diff Detail

Repository

R473 KTorrent

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

gassaf requested review of this revision.Nov 15 2019, 1:55 AM

gassaf created this revision.

gassaf added a task: T11609: Port KTorrent away from WebKit.Nov 15 2019, 2:05 AM

Who would be the correct person to review this? Apparently there is no current maintainer for ktorrent but stikonas seems to approve the latest changes to ktorrent?

I'll take a better look later.

Would you be able to switch to new Qt5 signals and slots on those lines that you touched?

mlaurent requested changes to this revision.Nov 22 2019, 6:06 AM

mlaurent added a subscriber: mlaurent.

mlaurent added inline comments.

plugins/search/magneturlschemehandler.h
32	explicit
plugins/search/searchwidget.cpp
94	new signal/slot syntax
plugins/search/webview.cpp
54	same
81	const

This revision now requires changes to proceed.Nov 22 2019, 6:06 AM

Thanks for the feedback, should be all fixed now.

gassaf marked 4 inline comments as done.Nov 24 2019, 11:59 PM

stikonas accepted this revision.Nov 25 2019, 12:05 AM

trufanov accepted this revision.Nov 25 2019, 10:25 AM

mlaurent accepted this revision.Nov 28 2019, 5:51 AM

This revision is now accepted and ready to land.Nov 28 2019, 5:51 AM

Closed by commit R473:f5a1958ebdca: Port KTorrent to QWebEngine (authored by gassaf). · Explain WhyNov 28 2019, 11:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		CMakeLists.txt (8 lines)
M		ktorrent/main.cpp (1 line)
M		plugins/CMakeLists.txt (4 lines)
M		plugins/search/CMakeLists.txt (8 lines)
D	M	plugins/search/buffernetworkreply.h (57 lines)
D	M	plugins/search/buffernetworkreply.cpp (65 lines)
D	M	plugins/search/localfilenetworkreply.h (52 lines)
D	M	plugins/search/localfilenetworkreply.cpp (79 lines)
A	M	plugins/search/magneturlschemehandler.h (39 lines)
A	M	plugins/search/magneturlschemehandler.cpp (34 lines)
M		plugins/search/searchwidget.h (6 lines)
M		plugins/search/searchwidget.cpp (62 lines)
M		plugins/search/webview.h (27 lines)
M		plugins/search/webview.cpp (98 lines)
M		plugins/syndication/CMakeLists.txt (2 lines)
M		plugins/syndication/feedwidget.h (1 line)
M		plugins/syndication/feedwidget.cpp (8 lines)
M		plugins/syndication/feedwidget.ui (12 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	69777			Nov 15 2019, 1:52 AM	★	★
Diff 2	70274			Nov 24 2019, 11:51 PM	★	★
Diff 3	70535	fa18fc6	R473:f5a1958ebdcacac8dd22a43623356dbf6bf6c34a	Nov 28 2019, 11:40 PM	★	★