Add static version of toQImageSilent()
ClosedPublic

Authored by trufanov on Jan 22 2019, 5:46 AM.

Details

Summary

Should be binary compatible.
Required for use in this https://phabricator.kde.org/D17955
Pls check description text and may be the order of exported functions should be different?

Diff Detail

Repository
R382 KSane Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
trufanov requested review of this revision.Jan 22 2019, 5:46 AM
trufanov created this revision.
sars accepted this revision.Jan 22 2019, 6:32 AM

Please commit!

This revision is now accepted and ready to land.Jan 22 2019, 6:32 AM
trufanov updated this revision to Diff 51407.Feb 11 2019, 1:19 PM

I've just realized that I forgot to add implementation of a new static func for TWAIN libksane version (ktwain_widget.cpp) AGAIN.
TWAIN ver is build for Windows only and mostly consists of stubs. Last time I forget about it it caused a lib compilation failure during CI autotests and I was traced by admin to fix this.
Luckily the patch wasn't commited yet.

So this diff is now with stubs for windows. I can't build for windows but it should be fine. I'll try to keep an eye for the next few KDE CI build statuses to make sure libksane for win is fine.

I'll commit this version today.

This revision was automatically updated to reflect the committed changes.