Differential D20696

Add DHT bootstrapping from well-known nodes
ClosedPublic
Actions

Authored by maxxim on Apr 20 2019, 10:39 AM.

Details

Reviewers

trufanov
stikonas

Commits

R472:b8e50493a93e: Add DHT bootstrapping from well-known nodes

Summary

This adds support for DHT bootstrapping from well-known nodes.

I decided to strip down the functionality to the bare minimum (no checks if bootstrap was successful, no retries etc.).

To test this, delete '~/.local/share/ktorrent/dht_table.ipv*' before starting KTorrent.

Port of https://git.reviewboard.kde.org/r/130083/

Diff Detail

Repository

R472 KTorrent Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

maxxim requested review of this revision.Apr 20 2019, 10:39 AM

maxxim created this revision.

maxxim edited the summary of this revision. (Show Details)

maxxim edited the summary of this revision. (Show Details)Apr 20 2019, 10:43 AM

stikonas accepted this revision.Apr 20 2019, 12:26 PM

This revision is now accepted and ready to land.Apr 20 2019, 12:26 PM

trufanov accepted this revision.Apr 20 2019, 12:36 PM

If I commit this myself, I need your mail address for git commit --author. Is it the same as in reviewboard (I can't see the one from Phabricator)?

In D20696#453545, @stikonas wrote:

If I commit this myself, I need your mail address for git commit --author. Is it the same as in reviewboard (I can't see the one from Phabricator)?

The author have replied me "I currently can't find the time to do this. Please commit this for me and use fonic.maxxim@live.com as the address for the author.".
He replied on phabricator;s email, so the answer isn't visible here.

Closed by commit R472:b8e50493a93e: Add DHT bootstrapping from well-known nodes (authored by maxxim, committed by stikonas). · Explain WhyMay 11 2019, 4:24 PM

This revision was automatically updated to reflect the committed changes.