This shall detect if device settings change was unsuccessful bcs scanning is in progress and automatically try to apply this change again when device becomes available.
requires https://phabricator.kde.org/D17510
Details
Details
As Skanlite blocks UI during scanning the only way to test this is by attaching some D-Bus hotkeys to some settings profiles and try to use these hotkeys for settings switching while scanning is in progress.
Diff Detail
Diff Detail
- Repository
- R483 Skanlite
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/skanlite.cpp | ||
|---|---|---|
| 674 | Perhaps but I would rather do this for uniformality. Usage applyScannerOptions instead of direct call to setOptVals I consider more safe and tried to replace all its occurrences with this variant. There are no more setOptVals in code except one in applyScannerOptions after this patch. | |
| src/skanlite.h | ||
| 106 | Well, I guess empty QScopedPointer takes a few bytes less RAM than empty QMap . And the case when it's non empty is quite rare and can be (currently) reached only via D-Bus hotkeys. Guess it's just my Symbian smartphone coding background cause me minimize RAM usage. I don't mind to change this. | |
Comment Actions
I was under the impression that you already where planning to remove the QScopedPointer... so I was waiting for that update. I would prefer to have the pointer removed for the readability of the code.
Regarding the other comment I had, it is OK as it is.