Feed Advanced Search

Apr 12 2020

heikobecker committed R181:87183927e210: Use desktop entry spec compliant X-KDE-ServiceTypes keys (authored by heikobecker).
Use desktop entry spec compliant X-KDE-ServiceTypes keys
Apr 12 2020, 9:35 PM
heikobecker committed R181:2884c29c0714: No need to set CMAKE_MODULE_PATH again (authored by heikobecker).
No need to set CMAKE_MODULE_PATH again
Apr 12 2020, 9:35 PM
heikobecker committed R181:5ce6dd2b4768: Make icons look sharp with HiDPI (authored by heikobecker).
Make icons look sharp with HiDPI
Apr 12 2020, 9:35 PM
heikobecker committed R181:a41a086e0564: Set StartupWMClass in desktop file (authored by heikobecker).
Set StartupWMClass in desktop file
Apr 12 2020, 9:35 PM
heikobecker committed R181:c7dc86335237: Use currentDateTimeUtc().toTime_t() (authored by heikobecker).
Use currentDateTimeUtc().toTime_t()
Apr 12 2020, 11:07 AM
heikobecker committed R181:fa9cae980836: Port from {from,to}Time_t to {from,to}SecsSinceEpoch (authored by heikobecker).
Port from {from,to}Time_t to {from,to}SecsSinceEpoch
Apr 12 2020, 11:07 AM
heikobecker committed R181:2cd1de69045b: Remove Phabricator's .arcconfig (authored by heikobecker).
Remove Phabricator's .arcconfig
Apr 12 2020, 9:58 AM
heikobecker committed R181:061dbe3f30e0: Remove nepmukcollection (authored by heikobecker).
Remove nepmukcollection
Apr 12 2020, 9:58 AM

Apr 11 2020

heikobecker added a comment to D28593: Fix copying and moving files to collection.

Oh, and although it was closed because of a missing backtrace it looks like this would fix: https://bugs.kde.org/show_bug.cgi?id=411716

Apr 11 2020, 11:03 AM · Qt 5 Porting, Amarok
heikobecker accepted D28593: Fix copying and moving files to collection.
Apr 11 2020, 11:00 AM · Qt 5 Porting, Amarok
heikobecker accepted D28284: Add FindMariaDB.cmake module and use it if MySQL is not found.
Apr 11 2020, 10:31 AM · Amarok
heikobecker accepted D27949: Conclude porting of Last.fm to Amarok KF5.
Apr 11 2020, 10:04 AM · Amarok

Apr 10 2020

heikobecker committed R8:d3355f511fe5: Merge branch 'calligra/3.1' (authored by heikobecker).
Merge branch 'calligra/3.1'
Apr 10 2020, 10:30 AM

Apr 9 2020

heikobecker abandoned D28398: Use Qt::SplitBehavior enum instead of QString::SplitBehavior.

Already done in 3fb633159ca4a1db166d5c54bbc025f71aba1652.

Apr 9 2020, 11:02 AM · Plasma

Apr 7 2020

heikobecker committed R228:fbda048247f0: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 7 2020, 3:50 PM
heikobecker committed R228:1ac41b6b2913: Fix build with Qt >= 5.15.0-beta3 (authored by heikobecker).
Fix build with Qt >= 5.15.0-beta3
Apr 7 2020, 3:49 PM
heikobecker committed R351:9a0cfb378cfc: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 7 2020, 3:46 PM
heikobecker committed R351:b10791980083: Fix build with Qt >= 5.15.0-beta3 (authored by heikobecker).
Fix build with Qt >= 5.15.0-beta3
Apr 7 2020, 3:45 PM
heikobecker committed R350:cca299bbb8cf: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 7 2020, 3:43 PM
heikobecker committed R350:536102db8cbd: Fix build with Qt >= 5.15.0-beta3 (authored by heikobecker).
Fix build with Qt >= 5.15.0-beta3
Apr 7 2020, 3:42 PM
heikobecker committed R340:b79a0fa17095: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 7 2020, 3:41 PM
heikobecker committed R340:12c8e6b5cf28: Fix build with Qt >= 5.15.0-beta3 (authored by heikobecker).
Fix build with Qt >= 5.15.0-beta3
Apr 7 2020, 3:40 PM
heikobecker committed R327:111a22559a63: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 7 2020, 3:36 PM
heikobecker committed R327:107628d6c4e1: Fix build with Qt >= 5.15.0-beta3 (authored by heikobecker).
Fix build with Qt >= 5.15.0-beta3
Apr 7 2020, 3:35 PM
heikobecker committed R332:ef07e5843b65: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 7 2020, 3:34 PM
heikobecker committed R332:ae8546be8e5e: Fix build with Qt >= 5.15.0-beta3 (authored by heikobecker).
Fix build with Qt >= 5.15.0-beta3
Apr 7 2020, 3:31 PM
heikobecker committed R158:4ab68cea04e5: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 7 2020, 3:28 PM
heikobecker committed R158:8984bf805c0d: Fix build with Qt 5.15.0-beta3 (authored by heikobecker).
Fix build with Qt 5.15.0-beta3
Apr 7 2020, 3:25 PM
heikobecker committed R418:604982765811: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 7 2020, 11:35 AM
heikobecker committed R418:4ae7ae8f7816: Fix build with Qt >= 5.15.0-beta3 (authored by heikobecker).
Fix build with Qt >= 5.15.0-beta3
Apr 7 2020, 11:33 AM
heikobecker committed R409:39cd6c055b40: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 7 2020, 11:11 AM
heikobecker committed R409:9034ef5c9ec3: Fix build with Qt >= 5.15.0-beta3 (authored by heikobecker).
Fix build with Qt >= 5.15.0-beta3
Apr 7 2020, 11:10 AM
heikobecker committed R407:f47ec4da092b: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 7 2020, 11:03 AM
heikobecker committed R407:2b063917bb18: Fix build with Qt >= 5.15.0-beta3 (authored by heikobecker).
Fix build with Qt >= 5.15.0-beta3
Apr 7 2020, 11:02 AM
heikobecker committed R405:affac9391323: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 7 2020, 10:57 AM
heikobecker committed R405:4fecfa1a9fc3: Fix build with Qt >= 5.15.0-beta3 (authored by heikobecker).
Fix build with Qt >= 5.15.0-beta3
Apr 7 2020, 10:55 AM
heikobecker committed R425:eff035f85152: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 7 2020, 10:04 AM
heikobecker committed R425:bead1e9613eb: Fix build with Qt >= 5.15.0-beta3 (authored by heikobecker).
Fix build with Qt >= 5.15.0-beta3
Apr 7 2020, 10:04 AM
heikobecker committed R81:e072f35a8fcd: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 7 2020, 9:34 AM
heikobecker committed R81:f74b0816350d: Fix build with Qt >= 5.15.0-beta3 (authored by heikobecker).
Fix build with Qt >= 5.15.0-beta3
Apr 7 2020, 9:23 AM
heikobecker committed R199:6904a9947c6b: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 7 2020, 8:39 AM
heikobecker committed R199:423cc560303d: Fix build with Qt >= 5.15.0-beta3 (authored by heikobecker).
Fix build with Qt >= 5.15.0-beta3
Apr 7 2020, 8:37 AM
heikobecker committed R168:c58f5da9ba7f: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 7 2020, 7:18 AM
heikobecker committed R168:b0fd83ba70de: Qt 5.15 undeprecated QComboBox::currentIndexChanged(int) (authored by dfaure).
Qt 5.15 undeprecated QComboBox::currentIndexChanged(int)
Apr 7 2020, 7:17 AM

Apr 6 2020

heikobecker committed R210:75772e32a1c6: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 6 2020, 11:08 PM
heikobecker committed R210:cc87c7fca52d: Fix building against Qt >= 5.15.0-beta3 (authored by heikobecker).
Fix building against Qt >= 5.15.0-beta3
Apr 6 2020, 11:04 PM
heikobecker added a reverting change for R210:990e4bedbdb6: Make it compile against last qt5.15 without deprecated method: R210:cc87c7fca52d: Fix building against Qt >= 5.15.0-beta3.
Apr 6 2020, 11:04 PM
heikobecker committed R318:180b7cb376d8: Merge remote-tracking branch 'origin/release/20.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/release/20.04'
Apr 6 2020, 9:13 PM
heikobecker committed R493:c8fcf6d722fe: Use auto (authored by heikobecker).
Use auto
Apr 6 2020, 8:51 PM
heikobecker committed R493:3526da6b5fb5: Use nullptr (authored by heikobecker).
Use nullptr
Apr 6 2020, 8:51 PM
heikobecker committed R493:01552627b3ed: Don't use deprecated headers (authored by heikobecker).
Don't use deprecated headers
Apr 6 2020, 8:51 PM
heikobecker committed R493:4feaa5df1dc8: Use override (authored by heikobecker).
Use override
Apr 6 2020, 8:51 PM
heikobecker committed R493:0319e6d4c13b: clang-format everything (authored by heikobecker).
clang-format everything
Apr 6 2020, 8:51 PM
heikobecker committed R493:0d9ce3ddabeb: Fix running devicestest after requiring >= ECM 5.38 (authored by heikobecker).
Fix running devicestest after requiring >= ECM 5.38
Apr 6 2020, 8:51 PM
heikobecker committed R493:a5f5bb8f451e: Remove X-DCOP-Service* entries from desktop file (authored by heikobecker).
Remove X-DCOP-Service* entries from desktop file
Apr 6 2020, 8:51 PM
heikobecker committed R493:ccb26fbd78b6: Add KDEClangFormat (authored by heikobecker).
Add KDEClangFormat
Apr 6 2020, 8:51 PM
heikobecker committed R493:bccba84363c5: build: Use project() to set the version (authored by heikobecker).
build: Use project() to set the version
Apr 6 2020, 8:51 PM
heikobecker committed R493:dfde5ad479ca: Set StartupWMClass in desktop file (authored by heikobecker).
Set StartupWMClass in desktop file
Apr 6 2020, 8:51 PM
heikobecker committed R493:7a6306e3f6a6: Install desktop file with exec flag (authored by heikobecker).
Install desktop file with exec flag
Apr 6 2020, 8:51 PM
heikobecker committed R493:73a2ca971c38: Use URLs with transport encryption (authored by heikobecker).
Use URLs with transport encryption
Apr 6 2020, 8:51 PM
heikobecker committed R493:49947b387f81: Use single quotes (authored by heikobecker).
Use single quotes
Apr 6 2020, 8:51 PM
heikobecker committed R318:d868568d81c7: Revert "Port deprecated signal (qt5.15)" (authored by apol).
Revert "Port deprecated signal (qt5.15)"
Apr 6 2020, 8:39 PM
heikobecker added a reverting change for R318:e545efee73a8: Port deprecated signal (qt5.15): R318:d868568d81c7: Revert "Port deprecated signal (qt5.15)".
Apr 6 2020, 8:39 PM

Apr 4 2020

heikobecker abandoned D28257: Defuse pontential future build errors.

Obsoleted by aab5b8808ba163552f0fac1a4992b167028863f3

Apr 4 2020, 9:30 PM

Mar 30 2020

heikobecker committed R875:c9aad1ec0a68: Merge remote-tracking branch 'origin/Falkon/3.1' (authored by heikobecker).
Merge remote-tracking branch 'origin/Falkon/3.1'
Mar 30 2020, 8:29 PM
heikobecker committed R875:2ca83509dbc7: Fix build with Qt 5.15 (authored by heikobecker).
Fix build with Qt 5.15
Mar 30 2020, 7:46 PM

Mar 29 2020

heikobecker added a comment to D28398: Use Qt::SplitBehavior enum instead of QString::SplitBehavior.
In D28398#637401, @apol wrote:

If plasma pass is part of plasma, which I'm not sure of, you can consider just bumping the required Qt version to Qt 5.14, as it will be the minimum Qt for Plasma 5.19.

Mar 29 2020, 8:38 PM · Plasma
heikobecker committed R1026:f77fb06dc5d9: Fix build with Qt 5.15 (authored by heikobecker).
Fix build with Qt 5.15
Mar 29 2020, 8:10 PM
heikobecker closed D28403: Fix build with Qt 5.15.
Mar 29 2020, 8:10 PM
heikobecker committed R8:12b178b452eb: Fix build with Qt 5.15 (authored by heikobecker).
Fix build with Qt 5.15
Mar 29 2020, 7:57 PM
heikobecker requested review of D28403: Fix build with Qt 5.15.
Mar 29 2020, 11:58 AM
heikobecker requested review of D28398: Use Qt::SplitBehavior enum instead of QString::SplitBehavior.
Mar 29 2020, 9:32 AM · Plasma

Mar 27 2020

heikobecker added a comment to D28248: Use another icon for the user feedback KCModule.

It is, e.g. Plasma (systemsettings) and Kate:

Mar 27 2020, 6:36 PM · KDE PIM
heikobecker committed R1032:5c6f65553d87: Use Qt::SplitBehavior enum instead of QString::SplitBehavior (authored by heikobecker).
Use Qt::SplitBehavior enum instead of QString::SplitBehavior
Mar 27 2020, 3:24 PM
heikobecker closed D28350: Use Qt::SplitBehavior enum instead of QString::SplitBehavior.
Mar 27 2020, 3:24 PM
heikobecker requested review of D28350: Use Qt::SplitBehavior enum instead of QString::SplitBehavior.
Mar 27 2020, 3:08 PM

Mar 26 2020

heikobecker committed R557:03ddc87b9336: Fix build with Qt 5.15 (authored by heikobecker).
Fix build with Qt 5.15
Mar 26 2020, 10:07 PM
heikobecker committed R181:7d8f4bfa8b5d: Fix compatibility with modern MySQL (authored by vmatare).
Fix compatibility with modern MySQL
Mar 26 2020, 8:37 PM
heikobecker closed D28165: Fix compatibility with modern MySQL.
Mar 26 2020, 8:37 PM · Amarok
heikobecker committed R181:edd580167b28: DiagnosticDialog: Use QStringLiteral (authored by heikobecker).
DiagnosticDialog: Use QStringLiteral
Mar 26 2020, 8:22 PM
heikobecker committed R181:4ae84cd43386: Fix a crash when trying to open the DiagnosticDialog (authored by heikobecker).
Fix a crash when trying to open the DiagnosticDialog
Mar 26 2020, 8:22 PM
heikobecker committed R181:33c88dfa81d3: Fix duplicate include guard (authored by heikobecker).
Fix duplicate include guard
Mar 26 2020, 8:22 PM
heikobecker committed R368:56ab7a29941e: Drop unnecessary and deprecated endl (authored by heikobecker).
Drop unnecessary and deprecated endl
Mar 26 2020, 7:12 AM
heikobecker closed D28255: Use Qt::endl instead of the deprecated ::endl.
Mar 26 2020, 7:12 AM

Mar 25 2020

heikobecker added a comment to D28255: Use Qt::endl instead of the deprecated ::endl.

the endl is really not needed though, is it? i mean

qWarning() << "Folder does not exist or is not readable: " << folder;

already adds a newline at the end, doesn't it?

Mar 25 2020, 7:20 PM
heikobecker updated the diff for D28255: Use Qt::endl instead of the deprecated ::endl.

Removed the endl

Mar 25 2020, 7:19 PM
heikobecker committed R368:9d66913f9042: Fix build with Qt 5.15 by adding an include (authored by heikobecker).
Fix build with Qt 5.15 by adding an include
Mar 25 2020, 7:14 PM
heikobecker committed R368:3ddd4032c48e: Port from qsrand to QRandomGenerator (authored by heikobecker).
Port from qsrand to QRandomGenerator
Mar 25 2020, 7:14 PM
heikobecker closed D28256: Fix build with Qt 5.15 by adding an include.
Mar 25 2020, 7:14 PM
heikobecker closed D28254: Port from qsrand to QRandomGenerator.
Mar 25 2020, 7:14 PM
heikobecker added inline comments to D27949: Conclude porting of Last.fm to Amarok KF5.
Mar 25 2020, 4:12 PM · Amarok
heikobecker accepted D28165: Fix compatibility with modern MySQL.

Builds fine here with mariadb and WITH_MYSQL_EMBEDDED=TRUE.

Mar 25 2020, 3:36 PM · Amarok

Mar 24 2020

heikobecker added a comment to D28248: Use another icon for the user feedback KCModule.

Well, I'd argue that a) the preferences-desktop-locale icon provides a visual clue what the entry is about and b) is consistent with other applications by KDE.

Mar 24 2020, 10:21 PM · KDE PIM
heikobecker abandoned D28252: Use another icon for the user feedback KCModule.

Actually, this is moot.

Mar 24 2020, 10:20 PM · KDE PIM
heikobecker added a comment to D28252: Use another icon for the user feedback KCModule.

Well, I'd argue that a) the preferences-desktop-locale icon provides a visual clue what the entry is about and b) is consistent with other applications by KDE.

Mar 24 2020, 9:52 PM · KDE PIM
heikobecker requested review of D28257: Defuse pontential future build errors.
Mar 24 2020, 7:45 PM
heikobecker added a dependent revision for D28255: Use Qt::endl instead of the deprecated ::endl: D28256: Fix build with Qt 5.15 by adding an include.
Mar 24 2020, 7:42 PM
heikobecker requested review of D28256: Fix build with Qt 5.15 by adding an include.
Mar 24 2020, 7:42 PM
heikobecker requested review of D28255: Use Qt::endl instead of the deprecated ::endl.
Mar 24 2020, 7:40 PM
heikobecker added a dependent revision for D28254: Port from qsrand to QRandomGenerator: D28255: Use Qt::endl instead of the deprecated ::endl.
Mar 24 2020, 7:40 PM