Differential D28398

Use Qt::SplitBehavior enum instead of QString::SplitBehavior
AbandonedPublic
Actions

Authored by heikobecker on Mar 29 2020, 9:32 AM.

Details

Reviewers
dvratil
Summary

The former was introduced with Qt 5.14 while the latter was deprecated
with 5.15 [1], causing the build to fail with that Qt version (because
of -DQT_DISABLE_DEPRECATED_BEFORE=0x060000).

Test Plan

Builds

Diff Detail

Repository
R1028 Plasma Pass
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24410
Build 24428: arc lint + arc unit
heikobecker created this revision.Mar 29 2020, 9:32 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 29 2020, 9:32 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
heikobecker requested review of this revision.Mar 29 2020, 9:32 AM
apol added a subscriber: apol.Mar 29 2020, 4:29 PM

+1

If plasma pass is part of plasma, which I'm not sure of, you can consider just bumping the required Qt version to Qt 5.14, as it will be the minimum Qt for Plasma 5.19.

heikobecker added a comment.Mar 29 2020, 8:38 PM
In D28398#637401, @apol wrote:

If plasma pass is part of plasma, which I'm not sure of, you can consider just bumping the required Qt version to Qt 5.14, as it will be the minimum Qt for Plasma 5.19.

It isn't part of plasma.

Revision Contents
Changeset List

PathPackages
Mplugin/passwordfiltermodel.cpp (4 lines)

Diff 78779

View Options

plugin/passwordfiltermodel.cpp

Loading...