Use another icon for the user feedback KCModule
AbandonedPublic

Authored by heikobecker on Tue, Mar 24, 6:18 PM.

Details

Reviewers
mlaurent
Group Reviewers
KDE PIM
Summary

It's the same that plasma, discover and kate use and a bit more
telling than the current one.

Test Plan

Builds, runs and new icon appears

Diff Detail

Repository
R206 KMail
Branch
release/20.04
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24172
Build 24190: arc lint + arc unit
heikobecker created this revision.Tue, Mar 24, 6:18 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptTue, Mar 24, 6:18 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
heikobecker requested review of this revision.Tue, Mar 24, 6:18 PM
mlaurent requested changes to this revision.Tue, Mar 24, 9:44 PM
mlaurent added a subscriber: mlaurent.

Yep but not. I changed it as I don't like this one.

This revision now requires changes to proceed.Tue, Mar 24, 9:44 PM

Well, I'd argue that a) the preferences-desktop-locale icon provides a visual clue what the entry is about and b) is consistent with other applications by KDE.

(Besides that I just noticed a typo in this diff :( )

heikobecker abandoned this revision.Tue, Mar 24, 10:20 PM

Actually, this is moot.