Looks alright. I'll try to compile myself and see what are those linking errors when you have those two lines uncommented...
Sat, Jul 13
Thu, Jul 11
Mon, Jul 8
-i bytes-per-inodeI am a bit worried that this API would be hard to use from GUI clients. Although in general, I think direction is good.
Mon, Jun 24
Sat, Jun 22
Jun 15 2019
I think QSignalSpy is in QtTest, not QtWidgets.
Jun 9 2019
So far rest seems alright.
Can you also mention motivation in commit message
Jun 8 2019
Once issues mentioned above are fixed.
Oh, I see. Sorry for missing that out. Then I guess commit it to master.
If you want this commit, you can just merge master branch into your branch.
Jun 7 2019
Looks good, just keep space consistent where I mentioned. Then you can push this to master branch.
I think startHelper() is much better.
Jun 6 2019
Jun 5 2019
Jun 3 2019
Jun 2 2019
Jun 1 2019
Hmm, regarding license, I guess it will be fine. KTorrent is GPLv2 or later. So GPLv3 would work.
Yes, it looks fine to me too. Please fix those issues that wbauer already mentioned and then you can commit (or ask somebody to commit if for you if you don't have commit access).
May 31 2019
May 30 2019
May 25 2019
May 24 2019
There are some procedures missing in this test. First, you need to look if mdadm is installed in the system before testing RAID. Then, you need to test the creation of a RAID device and check if it was successfully created. After that, you can try to create partitions on it and test if it exists.
May 23 2019
May 21 2019
Maybe push to 4.0 branch?
May 19 2019
May 18 2019
May 17 2019
Also in general, I think we should create a bool variable where we store data, so that we only run this
Well, in principle both mean exactly the same thing, so I don't have strong opinion on this. I probably use them interchangeably anyway. Well, it's auto, so we don't care what type it is... So based on that I would say no need to make a commit. Other parts of KDE codebase also don't have unified style here. Just checked kwin, it has both auto and auto *
Yesterday I tried for putting theses revisions over gitLab. but could not succeed. I tried doing git push origin master and it said access denied. So what should I do now to push it remote and the merge? Thanks
I have commit access, but It says access denied. Remember you had said it is hosted on remote server.
Oh, I do by running kdesrc-build script, which takes care of removing old build directory.
Please push this and the other revision on my behalf : )
oh ok, that's fine then.
please test that it builds in a clean build dir.
I do not know what do you mean? tests?
We also don't need this. Q_SLOTS are needed with old style Qt syntax where SIGNAL and SLOTS are used. With the new Qt5 connect syntax, you can just connect to any function, so no need to involve moc on this function.
The other include (#include "externalcommandhelper.h") I think can still go away but please test that it builds in a clean build dir.
It is needed by std::unique_ptr and std::unordered_set. We shouldn't rely on header being pulled in by some other header.
May 16 2019
May 12 2019
Maybe push to 4.0 branch?
May 11 2019
May 10 2019
May 2 2019
May 1 2019
Apr 30 2019
Apr 27 2019
Apr 23 2019
Apr 22 2019
Apr 21 2019
If I commit this myself, I need your mail address for git commit --author. Is it the same as in reviewboard (I can't see the one from Phabricator)?
It runtime requires Qt 5.12 for xdg-output which the shell needs for fullscreen, which means we can merge for Plasma 5.16
Apr 20 2019
Apr 19 2019
Apr 17 2019
Apr 13 2019
Apr 11 2019
Apr 6 2019
Apr 5 2019
Looks alright, although I wouldn't call that thing a typo. Variable names in C++ doesn't have to match in function header and implementation, although, it's probably less confusing if they match. But sometimes one can simply omit names in header and just have types.
Mar 29 2019
We also need to adapt this connect KJob to the Qt5 signals and slots syntax.
I don't think we should change other lines too here. We pass that percent to KJob, so keep the type the same as KJob expects.