No commit access, email is matt.scheirer@gmail.com

I've been slowly plugging away at a KCM to manage libinput tablets over here. Making it work on X first before trying to get KWin tablet support up to get it working there too.

Testing out the beta release that includes this change has the search bar overflow the menu list with high (160, in the example) DPI settings:

Since Qt 5.13's beta came out I got around to reading the XCB QT plugin source and nothing is making tablet move events not advertise buttons, so it must be in Xinput itself. Also no patches since 5.12 released that could explain the behavior change. So this patch still works fine on my end with the latest trunk and Qt 5.12 and 5.13. Might be worth noting I'm using libxcb 1.13.1 but thats still from last October.

In D17793#397404, @dkazakov wrote:

From the log it looks like "Mouse Move" events do not have proper "buttons" field set. Therefore it recognizes teh button as being released.

In D17793#388880, @dkazakov wrote:

Basically, when clicking with a custom shortcut, the action is started, but as soon as the first MouseMove event arrives, the action is terminated :(

Cleaned up the priority and traced all the way from KisShortcutConfiguration::deserialize to KisToolPaint::mousePressEvent looking for why tool actions would fail with ExtraButtons. The buttons always register - if I turn on krita.input logging buttons are recognized and tools are run properly but nothing would happen.

Working on button handling on Christmas, I feel like such a dork, but the family already left!