Differential D26411

Import KStatusBarOfflineIndicator from KIO
ClosedPublic
Actions

Authored by nicolasfella on Jan 4 2020, 2:54 AM.

Tags

None

Subscribers

None

Details

Reviewers

guisson
stikonas
shaforostoff

Maniphest Tasks

T12373: Move or kill KStatusBarOfflineIndicator

Commits

R473:26052bd35d6e: Import KStatusBarOfflineIndicator from KIO

Summary

KTorrent is the only user of this class and it doesn't really belong into KIO. Importing it here will allow to get rid of it in KIO.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

nicolasfella requested review of this revision.Jan 4 2020, 2:54 AM

nicolasfella created this revision.

Harbormaster completed remote builds in B20601: Diff 72725.Jan 4 2020, 2:54 AM

nicolasfella added a task: T12373: Move or kill KStatusBarOfflineIndicator.Jan 4 2020, 2:54 AM

nicolasfella added reviewers: guisson, stikonas, shaforostoff.

stikonas accepted this revision.Jan 25 2020, 11:03 AM

This revision is now accepted and ready to land.Jan 25 2020, 11:03 AM

Closed by commit R473:26052bd35d6e: Import KStatusBarOfflineIndicator from KIO (authored by nicolasfella). · Explain WhyFeb 5 2020, 11:11 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			ktorrent/CMakeLists.txt (1 line)
M			ktorrent/statusbar.cpp (4 lines)
A	M		ktorrent/statusbarofflineindicator.h (49 lines)
A	M		ktorrent/statusbarofflineindicator.cpp (83 lines)

Diff 75042

ktorrent/CMakeLists.txt

Loading...

ktorrent/statusbar.cpp

Loading...

ktorrent/statusbarofflineindicator.h

Loading...

ktorrent/statusbarofflineindicator.cpp

Loading...