Differential D27733

Set a better position on wayland
AbandonedPublic
Actions

Authored by trmdi on Feb 29 2020, 7:34 AM.

Details

Reviewers
davidedmundson
hein
Group Reviewers
Yakuake
Konsole
Summary

On wayland, we could get a better work area from plasmashell through dbus.
Similar to this patch: https://phabricator.kde.org/D27458

CCBUG: 386114

Test Plan

Yakuake isn't overlapped by a top panel in all cases

Diff Detail

Repository
R369 Yakuake
Branch
fix-position-on-wayland (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23080
Build 23098: arc lint + arc unit
trmdi requested review of this revision.Feb 29 2020, 7:34 AM
trmdi created this revision.
trmdi edited the summary of this revision. (Show Details)Feb 29 2020, 7:37 AM
trmdi abandoned this revision.Apr 5 2020, 3:28 AM
stikonas added a subscriber: stikonas.Jun 4 2020, 11:43 PM

Is there any reason why this is abandonned? It seems to work fine on my system.

trmdi added a comment.Jun 5 2020, 12:43 AM
In D27733#674638, @stikonas wrote:

Is there any reason why this is abandonned? It seems to work fine on my system.

Because it seemed no one wanted to review it.

stikonas added a comment.Jun 5 2020, 12:45 AM

I can try to look at it this weekend, but maybe open it on invent.kde.org

stikonas added a comment.Jun 5 2020, 7:04 PM

OK, the patch looks fine. I would suggest pushing it.

It does not deal with the case of non-plasma wayland compositor but I just tested yakuake on Gnome Wayland and it horribly broken anyway.

trmdi added a comment.Jun 6 2020, 2:53 AM
In D27733#674689, @stikonas wrote:

OK, the patch looks fine. I would suggest pushing it.

It does not deal with the case of non-plasma wayland compositor but I just tested yakuake on Gnome Wayland and it horribly broken anyway.

https://invent.kde.org/utilities/yakuake/-/merge_requests/10

Ok, I will push it in several days if no one disagrees.

pejakm added a subscriber: pejakm.Jun 6 2020, 12:44 PM

Revision Contents
Changeset List

PathPackages
Mapp/mainwindow.h (4 lines)
Mapp/mainwindow.cpp (25 lines)

Diff 76668

View Options

app/mainwindow.h

Loading...
View Options

app/mainwindow.cpp

Loading...