Feed Advanced Search

Advanced Search
Use Results
Hide Query

Dec 4 2017

renatoo updated the diff for D8855: Use Kio::KPlacesModel as source model for PlacesItemModel.

Fixed typo

Dec 4 2017, 12:31 PM · Dolphin
renatoo updated the diff for D8855: Use Kio::KPlacesModel as source model for PlacesItemModel.

Fixed typo
Used QScopedPointer for m_sourceModel
Fixed code style

Dec 4 2017, 12:27 PM · Dolphin

Dec 1 2017

renatoo updated the diff for D8855: Use Kio::KPlacesModel as source model for PlacesItemModel.

Rebased with mainline

Dec 1 2017, 8:08 PM · Dolphin

Nov 29 2017

renatoo added a comment to D8243: Implement support for categories on KfilesPlacesView.
In D8243#173442, @broulik wrote:

Can we expose the group type enum in the model in addition to the name, so I can do some filtering in e.g. task manager?

Nov 29 2017, 4:51 PM · Frameworks
renatoo updated the diff for D8855: Use Kio::KPlacesModel as source model for PlacesItemModel.

Used const for the function argument

Nov 29 2017, 12:08 PM · Dolphin

Nov 27 2017

renatoo updated the diff for D8630: Created unit test for PlacesItemModel.

Move test data file

Nov 27 2017, 2:45 PM
renatoo created D9017: Avoid run kfileplacesmodeltest and kfileplacesviewtest in parallel.
Nov 27 2017, 2:05 PM · Frameworks
renatoo updated the diff for D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'.

Updated parent branch

Nov 27 2017, 1:23 PM · Frameworks
renatoo updated the diff for D8947: Expose KFilePlacesModel 'iconName' role.

Updated parent branch

Nov 27 2017, 1:22 PM · Frameworks
renatoo updated the diff for D8946: Avoid unnecessary 'dataChanged' signal.

Updated parent branch

Nov 27 2017, 1:22 PM · Frameworks
renatoo updated the diff for D8945: Return a valid bookmark object for any entry in KFilePlacesModel.

Updated parent branch

Nov 27 2017, 1:21 PM · Frameworks
renatoo updated the diff for D8944: Create a 'KFilePlacesModel::refresh' function.

Updated parent branch

Nov 27 2017, 1:21 PM · Frameworks
renatoo updated the diff for D8943: Create 'KFilePlacesModel::convertedUrl' static function.

Updated parent branch

Nov 27 2017, 1:21 PM · Frameworks
renatoo added a comment to D8630: Created unit test for PlacesItemModel.
In D8630#172367, @elvisangelaccio wrote:

I'm getting this failure when running the test:

********* Start testing of PlacesItemModelTest *********
Config: Using QtTest library 5.10.0, Qt 5.10.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 7.2.0)
WARNING: PlacesItemModelTest::initTestCase() testdata fakecomputer.xml could not be located!
   Loc: [../src/tests/placesitemmodeltest.cpp(177)]
FAIL!  : PlacesItemModelTest::initTestCase() '!fakeHw.isEmpty()' returned FALSE. ()
   Loc: [../src/tests/placesitemmodeltest.cpp(178)]
PASS   : PlacesItemModelTest::cleanupTestCase()
Totals: 1 passed, 1 failed, 0 skipped, 0 blacklisted, 0ms

Am I missing something?

Nov 27 2017, 11:56 AM
renatoo updated the diff for D8855: Use Kio::KPlacesModel as source model for PlacesItemModel.

Updated parent branch

Nov 27 2017, 11:55 AM · Dolphin
renatoo updated the diff for D8630: Created unit test for PlacesItemModel.

Added missing file, necessary for unit test

Nov 27 2017, 11:55 AM

Nov 26 2017

renatoo updated the diff for D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'.

Updated parent branch

Nov 26 2017, 3:25 PM · Frameworks
renatoo updated the diff for D8947: Expose KFilePlacesModel 'iconName' role.

Updated parent branch

Nov 26 2017, 3:25 PM · Frameworks
renatoo updated the diff for D8946: Avoid unnecessary 'dataChanged' signal.

Updated parent branch

Nov 26 2017, 3:25 PM · Frameworks
renatoo updated the diff for D8945: Return a valid bookmark object for any entry in KFilePlacesModel.

Updated parent branch

Nov 26 2017, 3:24 PM · Frameworks
renatoo updated the diff for D8944: Create a 'KFilePlacesModel::refresh' function.

Updated parent branch

Nov 26 2017, 3:24 PM · Frameworks
renatoo updated the diff for D8943: Create 'KFilePlacesModel::convertedUrl' static function.

Updated parent branch

Nov 26 2017, 3:22 PM · Frameworks
renatoo updated the diff for D8434: Created 'remote' section.

Updated parent branch

Nov 26 2017, 3:22 PM · Frameworks
renatoo added a comment to D8348: Add a section for removable devices.
In D8348#172032, @ngraham wrote:

@renatoo, now that D8332 is in, this no patch longer applies cleanly. Can you update so I can land it?

Nov 26 2017, 1:28 PM · Frameworks
renatoo updated the diff for D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'.

Updated parent branch

Nov 26 2017, 1:27 PM · Frameworks
renatoo updated the diff for D8947: Expose KFilePlacesModel 'iconName' role.

Updated parent branch

Nov 26 2017, 1:27 PM · Frameworks
renatoo updated the diff for D8946: Avoid unnecessary 'dataChanged' signal.

Updated parent branch

Nov 26 2017, 1:26 PM · Frameworks
renatoo updated the diff for D8945: Return a valid bookmark object for any entry in KFilePlacesModel.

Updated parent branch

Nov 26 2017, 1:26 PM · Frameworks
renatoo updated the diff for D8944: Create a 'KFilePlacesModel::refresh' function.

Updated parent branch

Nov 26 2017, 1:25 PM · Frameworks
renatoo updated the diff for D8943: Create 'KFilePlacesModel::convertedUrl' static function.

Updated parent branch

Nov 26 2017, 1:25 PM · Frameworks
renatoo updated the diff for D8434: Created 'remote' section.

Updated parent branch

Nov 26 2017, 1:24 PM · Frameworks
renatoo updated the diff for D8348: Add a section for removable devices.

Updated parent branch

Nov 26 2017, 1:23 PM · Frameworks

Nov 23 2017

renatoo added a comment to D8332: Added baloo urls into places model.

@dvratil, @ervin any comments?

Nov 23 2017, 3:19 PM · Frameworks
renatoo added a comment to D8630: Created unit test for PlacesItemModel.

@elvisangelaccio any comments?

Nov 23 2017, 3:19 PM
renatoo added inline comments to D8630: Created unit test for PlacesItemModel.
Nov 23 2017, 2:04 PM
renatoo added a comment to D8855: Use Kio::KPlacesModel as source model for PlacesItemModel.
In D8855#170435, @elvisangelaccio wrote:

Please bump the minimum KIO version in CMakeLists.txt

Nov 23 2017, 1:28 PM · Dolphin
renatoo updated the diff for D8855: Use Kio::KPlacesModel as source model for PlacesItemModel.

Bumped KF5 dep version

Nov 23 2017, 1:26 PM · Dolphin
renatoo updated the diff for D8630: Created unit test for PlacesItemModel.

Rebased with upstream

Nov 23 2017, 1:26 PM
renatoo updated the diff for D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'.

Parent branch updated

Nov 23 2017, 11:54 AM · Frameworks
renatoo updated the diff for D8947: Expose KFilePlacesModel 'iconName' role.

Parent branch updated

Nov 23 2017, 11:54 AM · Frameworks
renatoo updated the diff for D8946: Avoid unnecessary 'dataChanged' signal.

Parent branch updated

Nov 23 2017, 11:54 AM · Frameworks
renatoo updated the diff for D8945: Return a valid bookmark object for any entry in KFilePlacesModel.

Parent branch updated

Nov 23 2017, 11:53 AM · Frameworks
renatoo updated the diff for D8944: Create a 'KFilePlacesModel::refresh' function.

Parent branch updated

Nov 23 2017, 11:53 AM · Frameworks
renatoo updated the diff for D8943: Create 'KFilePlacesModel::convertedUrl' static function.

Parent branch updated

Nov 23 2017, 11:53 AM · Frameworks
renatoo updated the diff for D8434: Created 'remote' section.

Parent branch updated

Nov 23 2017, 11:53 AM · Frameworks
renatoo updated the diff for D8348: Add a section for removable devices.

Parent branch updated

Nov 23 2017, 11:53 AM · Frameworks
renatoo updated the diff for D8332: Added baloo urls into places model.

Renamed test function

Nov 23 2017, 11:52 AM · Frameworks
renatoo updated the diff for D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'.

Fixed typos
Fixed code style

Nov 23 2017, 11:47 AM · Frameworks

Nov 22 2017

renatoo updated the diff for D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'.

Updated from master

Nov 22 2017, 7:16 PM · Frameworks
renatoo updated the diff for D8947: Expose KFilePlacesModel 'iconName' role.

Updated from master

Nov 22 2017, 7:16 PM · Frameworks
renatoo updated the diff for D8946: Avoid unnecessary 'dataChanged' signal.

Updated from master

Nov 22 2017, 7:16 PM · Frameworks
renatoo updated the diff for D8945: Return a valid bookmark object for any entry in KFilePlacesModel.

Updated from master

Nov 22 2017, 7:15 PM · Frameworks
renatoo updated the diff for D8944: Create a 'KFilePlacesModel::refresh' function.

Updated from master

Nov 22 2017, 7:15 PM · Frameworks
renatoo updated the diff for D8943: Create 'KFilePlacesModel::convertedUrl' static function.

Updated from master

Nov 22 2017, 7:15 PM · Frameworks
renatoo updated the diff for D8434: Created 'remote' section.

Updated from master

Nov 22 2017, 7:15 PM · Frameworks
renatoo updated the diff for D8348: Add a section for removable devices.

Updated from master

Nov 22 2017, 7:15 PM · Frameworks
renatoo updated the diff for D8332: Added baloo urls into places model.

Updated from master

Nov 22 2017, 7:14 PM · Frameworks
renatoo updated the diff for D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'.

Updated parent branch

Nov 22 2017, 5:58 PM · Frameworks
renatoo updated the diff for D8947: Expose KFilePlacesModel 'iconName' role.

Updated parent branch

Nov 22 2017, 5:58 PM · Frameworks
renatoo updated the diff for D8946: Avoid unnecessary 'dataChanged' signal.

Updated parent branch

Nov 22 2017, 5:58 PM · Frameworks
renatoo updated the diff for D8945: Return a valid bookmark object for any entry in KFilePlacesModel.

Updated parent branch

Nov 22 2017, 5:58 PM · Frameworks
renatoo updated the diff for D8944: Create a 'KFilePlacesModel::refresh' function.

Updated parent branch

Nov 22 2017, 5:57 PM · Frameworks
renatoo updated the diff for D8943: Create 'KFilePlacesModel::convertedUrl' static function.

Updated parent branch

Nov 22 2017, 5:57 PM · Frameworks
renatoo updated the diff for D8434: Created 'remote' section.

Updated parent branch

Nov 22 2017, 5:57 PM · Frameworks
renatoo updated the diff for D8348: Add a section for removable devices.

Updated parent branch

Nov 22 2017, 5:57 PM · Frameworks
renatoo updated the diff for D8332: Added baloo urls into places model.

Updated unit test name

Nov 22 2017, 5:56 PM · Frameworks
renatoo updated the diff for D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'.

Implemented unit test
Fixed documentation

Nov 22 2017, 5:44 PM · Frameworks
renatoo updated the diff for D8947: Expose KFilePlacesModel 'iconName' role.

Updated documentation

Nov 22 2017, 5:38 PM · Frameworks
renatoo updated the diff for D8946: Avoid unnecessary 'dataChanged' signal.

Updated parent branch

Nov 22 2017, 5:24 PM · Frameworks
renatoo updated the diff for D8945: Return a valid bookmark object for any entry in KFilePlacesModel.

Updated parent brach

Nov 22 2017, 5:24 PM · Frameworks
renatoo updated the diff for D8944: Create a 'KFilePlacesModel::refresh' function.

Updated parent branch

Nov 22 2017, 5:24 PM · Frameworks
renatoo updated the diff for D8943: Create 'KFilePlacesModel::convertedUrl' static function.

Updated documentation

Nov 22 2017, 5:23 PM · Frameworks
renatoo retitled D8947: Expose KFilePlacesModel 'iconName' role from Expose KFilePlacesModel 'iconName' rule to Expose KFilePlacesModel 'iconName' role.
Nov 22 2017, 5:21 PM · Frameworks
renatoo planned changes to D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'.

Implement unit test

Nov 22 2017, 2:27 PM · Frameworks
renatoo added a dependent revision for D8947: Expose KFilePlacesModel 'iconName' role: D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'.
Nov 22 2017, 2:26 PM · Frameworks
renatoo updated the summary of D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'.
Nov 22 2017, 2:26 PM · Frameworks
renatoo updated the summary of D8947: Expose KFilePlacesModel 'iconName' role.
Nov 22 2017, 2:26 PM · Frameworks
renatoo added a dependent revision for D8946: Avoid unnecessary 'dataChanged' signal: D8947: Expose KFilePlacesModel 'iconName' role.
Nov 22 2017, 2:26 PM · Frameworks
renatoo updated the summary of D8946: Avoid unnecessary 'dataChanged' signal.
Nov 22 2017, 2:25 PM · Frameworks
renatoo added a dependent revision for D8945: Return a valid bookmark object for any entry in KFilePlacesModel: D8946: Avoid unnecessary 'dataChanged' signal.
Nov 22 2017, 2:25 PM · Frameworks
renatoo added a dependent revision for D8944: Create a 'KFilePlacesModel::refresh' function: D8945: Return a valid bookmark object for any entry in KFilePlacesModel.
Nov 22 2017, 2:23 PM · Frameworks
renatoo updated the summary of D8945: Return a valid bookmark object for any entry in KFilePlacesModel.
Nov 22 2017, 2:23 PM · Frameworks
renatoo added a dependent revision for D8943: Create 'KFilePlacesModel::convertedUrl' static function: D8944: Create a 'KFilePlacesModel::refresh' function.
Nov 22 2017, 2:22 PM · Frameworks
renatoo updated the summary of D8944: Create a 'KFilePlacesModel::refresh' function.
Nov 22 2017, 2:22 PM · Frameworks
renatoo updated the summary of D8943: Create 'KFilePlacesModel::convertedUrl' static function.
Nov 22 2017, 2:21 PM · Frameworks
renatoo added a dependent revision for D8348: Add a section for removable devices: D8943: Create 'KFilePlacesModel::convertedUrl' static function.
Nov 22 2017, 2:21 PM · Frameworks
renatoo added a dependent revision for D8434: Created 'remote' section: D8943: Create 'KFilePlacesModel::convertedUrl' static function.
Nov 22 2017, 2:21 PM · Frameworks
renatoo added a dependent revision for D8332: Added baloo urls into places model: D8943: Create 'KFilePlacesModel::convertedUrl' static function.
Nov 22 2017, 2:21 PM · Frameworks
renatoo abandoned D8862: Extend KFilePlacesModel API.

This review was split in small ones:
D8943
D8944
D8945
D8946
D8947
D8948

Nov 22 2017, 2:21 PM · Frameworks
renatoo created D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'.
Nov 22 2017, 2:18 PM · Frameworks
renatoo created D8947: Expose KFilePlacesModel 'iconName' role.
Nov 22 2017, 2:18 PM · Frameworks
renatoo created D8946: Avoid unnecessary 'dataChanged' signal.
Nov 22 2017, 2:18 PM · Frameworks
renatoo added a reviewer for D8944: Create a 'KFilePlacesModel::refresh' function: dfaure.
Nov 22 2017, 2:17 PM · Frameworks
renatoo created D8945: Return a valid bookmark object for any entry in KFilePlacesModel.
Nov 22 2017, 2:17 PM · Frameworks
renatoo added a reviewer for D8943: Create 'KFilePlacesModel::convertedUrl' static function: dfaure.
Nov 22 2017, 2:17 PM · Frameworks
renatoo created D8944: Create a 'KFilePlacesModel::refresh' function.
Nov 22 2017, 2:16 PM · Frameworks
renatoo created D8943: Create 'KFilePlacesModel::convertedUrl' static function.
Nov 22 2017, 2:16 PM · Frameworks

Nov 21 2017

renatoo added inline comments to D8855: Use Kio::KPlacesModel as source model for PlacesItemModel.
Nov 21 2017, 7:44 PM · Dolphin
renatoo updated the diff for D8855: Use Kio::KPlacesModel as source model for PlacesItemModel.

Fixed item drag & drop

Nov 21 2017, 7:44 PM · Dolphin
renatoo updated the diff for D8862: Extend KFilePlacesModel API.

Created a public function 'moveItem' to be used by external apps

Nov 21 2017, 7:28 PM · Frameworks
First
Prev
Next