renatoo (Renato Oliveira Filho)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 11 2017, 12:33 PM (158 w, 1 h)
Availability
Available

Recent Activity

May 23 2018

renatoo requested review of D13061: Fixed kfileplacesviewtest when not running on empty home.
May 23 2018, 1:47 PM · Frameworks
renatoo added a comment to D13018: Fix unit test for kfileplacesmodeltest.
May 23 2018, 11:30 AM · Frameworks

May 22 2018

renatoo added a comment to D13018: Fix unit test for kfileplacesmodeltest.

I know you didn't change that, but it might be a nice enhancement (hint hint). :)

May 22 2018, 7:22 PM · Frameworks
renatoo updated the diff for D13018: Fix unit test for kfileplacesmodeltest.

Run tests in an empty home dir

May 22 2018, 7:22 PM · Frameworks
renatoo added a comment to D13018: Fix unit test for kfileplacesmodeltest.

Shouldn't that be a part of the test itself? I don't think it's reasonable to require that testers and testing platforms manually run that every time.

May 22 2018, 7:13 PM · Frameworks
renatoo added a comment to D13018: Fix unit test for kfileplacesmodeltest.

as maximilianocuria said, before run the tests you need to create a temporary home path:

May 22 2018, 7:03 PM · Frameworks
renatoo added a comment to D13018: Fix unit test for kfileplacesmodeltest.

ok it should work now.

May 22 2018, 1:31 PM · Frameworks
renatoo updated the diff for D13018: Fix unit test for kfileplacesmodeltest.

Fixed code style

May 22 2018, 1:26 PM · Frameworks
renatoo updated the diff for D13018: Fix unit test for kfileplacesmodeltest.

Fixed all tests

May 22 2018, 1:25 PM · Frameworks
renatoo updated the diff for D13018: Fix unit test for kfileplacesmodeltest.
May 22 2018, 1:24 PM · Frameworks

May 21 2018

renatoo updated the diff for D13018: Fix unit test for kfileplacesmodeltest.

Add missing url

May 21 2018, 2:26 PM · Frameworks
renatoo requested review of D13018: Fix unit test for kfileplacesmodeltest.
May 21 2018, 1:59 PM · Frameworks

Jan 24 2018

renatoo updated the diff for D9333: Make sure that old URLs do not appear duplicated in places model.

Renamed variable

Jan 24 2018, 12:47 PM
renatoo updated the diff for D9332: Allow filter places based on alternative application name.

Updated @since tag

Jan 24 2018, 12:41 PM · Frameworks

Jan 23 2018

renatoo updated the diff for D9333: Make sure that old URLs do not appear duplicated in places model.

Use QString instead of char[]

Jan 23 2018, 1:33 PM

Jan 21 2018

renatoo updated the diff for D9985: Fix place item edit after creation.

Fixed typo

Jan 21 2018, 2:06 PM
renatoo updated the diff for D9333: Make sure that old URLs do not appear duplicated in places model.

Fixed comments and code style

Jan 21 2018, 2:06 PM

Jan 19 2018

renatoo updated the diff for D9985: Fix place item edit after creation.

Fixed typo

Jan 19 2018, 5:21 PM
renatoo added a comment to D9347: Ignore baloo urls created from new KIO model.

Edit item fixed on: D9985 (do we have a bug report for that? or should I create one?)

Jan 19 2018, 4:43 PM
renatoo updated the diff for D9985: Fix place item edit after creation.

Rever unrelated changes

Jan 19 2018, 4:42 PM
renatoo updated the summary of D9985: Fix place item edit after creation.
Jan 19 2018, 4:40 PM
renatoo added a dependent revision for D9333: Make sure that old URLs do not appear duplicated in places model: D9985: Fix place item edit after creation.
Jan 19 2018, 4:40 PM
renatoo updated the diff for D9333: Make sure that old URLs do not appear duplicated in places model.

Solve conflics with mainline

Jan 19 2018, 4:39 PM
renatoo added a comment to D9347: Ignore baloo urls created from new KIO model.

yes. I can confirm that entries recently created can not be edited , But if you create it re-open dolphin you can edit the entries. (Working on a fix right now).

Jan 19 2018, 12:55 PM
renatoo added a comment to D9347: Ignore baloo urls created from new KIO model.

yes this code should be skipped on the mainline, but was not.

Jan 19 2018, 11:42 AM

Jan 16 2018

renatoo accepted D9863: Fix overlap of the first item in KFilePlacesView.

looks good

Jan 16 2018, 5:29 PM · Frameworks

Jan 8 2018

renatoo updated the diff for D9333: Make sure that old URLs do not appear duplicated in places model.

Avoid crash while filtering urls

Jan 8 2018, 4:30 PM
renatoo added a comment to D9347: Ignore baloo urls created from new KIO model.

Yes, please merge on master and then rebase D9333.

Jan 8 2018, 12:36 PM

Jan 2 2018

renatoo added a comment to D9347: Ignore baloo urls created from new KIO model.

Yes, please merge on master and then rebase D9333.

ok I will do that.

Jan 2 2018, 5:39 PM
renatoo updated the diff for D9332: Allow filter places based on alternative application name.

Fixed typo

Jan 2 2018, 4:37 PM · Frameworks
renatoo added a comment to D9347: Ignore baloo urls created from new KIO model.

Don't forget to merge your commits on the 17.12 branch back to master.

Jan 2 2018, 2:03 PM
renatoo updated the diff for D9347: Ignore baloo urls created from new KIO model.

Removed TODO comments

Jan 2 2018, 1:09 PM
renatoo added a comment to D9347: Ignore baloo urls created from new KIO model.
In D9347#184697, @cfeck wrote:

Does it only avoid duplicate timeline:/ and search:/ ? I have duplicate 'Devices' and 'Removable Devices' sections since recently, and I cannot right-click to remove them.

Jan 2 2018, 12:38 PM

Dec 26 2017

renatoo added a comment to D9347: Ignore baloo urls created from new KIO model.

What's the difference with D9333?

Dec 26 2017, 12:39 PM

Dec 20 2017

renatoo updated the diff for D9441: Fix PlacesItemModel loading with hidden devices.

Check for hidden item in 'addItemFromSourceModel'

Dec 20 2017, 6:53 PM
renatoo created D9441: Fix PlacesItemModel loading with hidden devices.
Dec 20 2017, 6:31 PM

Dec 18 2017

renatoo updated the diff for D9351: Fixed places side panel for baloo urls.

Check KIO version before use new API

Dec 18 2017, 2:07 PM

Dec 15 2017

renatoo updated the diff for D9351: Fixed places side panel for baloo urls.

Use explicit static function

Dec 15 2017, 4:34 PM
renatoo added a reviewer for D9351: Fixed places side panel for baloo urls: rkflx.
Dec 15 2017, 2:51 PM
renatoo created D9351: Fixed places side panel for baloo urls.
Dec 15 2017, 2:50 PM
renatoo updated the diff for D9347: Ignore baloo urls created from new KIO model.

Removed use of qWarning

Dec 15 2017, 12:38 PM
renatoo created D9347: Ignore baloo urls created from new KIO model.
Dec 15 2017, 12:14 PM
renatoo updated the diff for D9333: Make sure that old URLs do not appear duplicated in places model.

Updated changes

Dec 15 2017, 11:30 AM

Dec 14 2017

renatoo added a comment to D8332: Added baloo urls into places model.
In D8332#179633, @rkflx wrote:

This change caused a little bit of fallout for Gwenview. Apparently the review focussed more on the code, but less so on the behaviour in users of the class. I'm not complaining, but given one of our focus goals is on usability and quality of the basic apps, it would be great if:

  • changes were tested more broadly in the future in addition to only looking at the code
  • there was some help to fix the fallout

    Please head over to https://bugs.kde.org/show_bug.cgi?id=387824 if you can help Gwenview, thanks!

    ---

    In addition to Gwenview I also looked on lxr and did some testing based on what I found:
  • The sidebar in KDirSelectDialog is now awful to use, because
    • The devices entry (which for some users is more important/useful/frequently used than the search entries) is hidden from view (bad) and requires scrolling (annoying). → We should discuss reordering or (even better) adding collapsing and then collapsing some groups by default.
    • The additional scrollbar makes the sidebar so small that you can't read most of the entries. → Add splitter and improve default width.
  • To a lesser extent, this also applies to the normal file dialog (no scrollbar by default would be nice).
  • Filesystem sidebars in KDevelop, #Okteta, Kile, Kate and Krusader: Some of the entries do not make sense in some of those apps at all, e.g. Videos/Images/…. Also some entries show an error message or are broken / show nothing at all (while the same entry works fine in Dolphin).
  • That's it at first sight, luckily ;)

    Would be nice to fix those too… Let me know what's the best way forward here, i.e. what are Frameworks issues and where we'd need bugs filed against individual apps.
Dec 14 2017, 6:30 PM · Frameworks
renatoo updated the diff for D9332: Allow filter places based on alternative application name.

Added kf6 comments

Dec 14 2017, 5:35 PM · Frameworks
renatoo updated the diff for D9332: Allow filter places based on alternative application name.

Added documention for the new constructor

Dec 14 2017, 5:13 PM · Frameworks
renatoo updated the diff for D9333: Make sure that old URLs do not appear duplicated in places model.

Fixed typo

Dec 14 2017, 5:07 PM
renatoo updated the diff for D9333: Make sure that old URLs do not appear duplicated in places model.

Fixed typo

Dec 14 2017, 5:05 PM
renatoo added inline comments to D9332: Allow filter places based on alternative application name.
Dec 14 2017, 4:58 PM · Frameworks
renatoo updated the summary of D9332: Allow filter places based on alternative application name.
Dec 14 2017, 4:58 PM · Frameworks
renatoo updated the diff for D9332: Allow filter places based on alternative application name.

Avoid ABI break

Dec 14 2017, 4:57 PM · Frameworks
renatoo updated the summary of D9332: Allow filter places based on alternative application name.
Dec 14 2017, 3:53 PM · Frameworks
renatoo updated the summary of D9333: Make sure that old URLs do not appear duplicated in places model.
Dec 14 2017, 3:51 PM
renatoo updated the summary of D9332: Allow filter places based on alternative application name.
Dec 14 2017, 3:50 PM · Frameworks
renatoo updated the summary of D9332: Allow filter places based on alternative application name.
Dec 14 2017, 3:50 PM · Frameworks
renatoo updated the summary of D9332: Allow filter places based on alternative application name.
Dec 14 2017, 3:50 PM · Frameworks
renatoo updated the summary of D9332: Allow filter places based on alternative application name.
Dec 14 2017, 3:50 PM · Frameworks
renatoo added a reviewer for D9333: Make sure that old URLs do not appear duplicated in places model: mwolff.
Dec 14 2017, 3:48 PM
renatoo added a reviewer for D9332: Allow filter places based on alternative application name: mwolff.
Dec 14 2017, 3:48 PM · Frameworks
renatoo added a dependent revision for D9332: Allow filter places based on alternative application name: D9333: Make sure that old URLs do not appear duplicated in places model.
Dec 14 2017, 3:45 PM · Frameworks
renatoo updated the summary of D9333: Make sure that old URLs do not appear duplicated in places model.
Dec 14 2017, 3:45 PM
renatoo updated the summary of D9333: Make sure that old URLs do not appear duplicated in places model.
Dec 14 2017, 3:45 PM
renatoo created D9333: Make sure that old URLs do not appear duplicated in places model.
Dec 14 2017, 3:44 PM
renatoo updated the summary of D9332: Allow filter places based on alternative application name.
Dec 14 2017, 3:43 PM · Frameworks
renatoo created D9332: Allow filter places based on alternative application name.
Dec 14 2017, 3:42 PM · Frameworks

Dec 13 2017

renatoo added inline comments to D9242: Implemented support for hide/show groups.
Dec 13 2017, 12:02 PM

Dec 12 2017

renatoo added a comment to D9242: Implemented support for hide/show groups.

@elvisangelaccio could you try again?

Dec 12 2017, 12:50 PM

Dec 11 2017

renatoo added a comment to D9242: Implemented support for hide/show groups.

I can't apply this patch, can you please rebase it?

Dec 11 2017, 12:10 PM
renatoo updated the summary of D9242: Implemented support for hide/show groups.
Dec 11 2017, 12:09 PM

Dec 8 2017

renatoo added a comment to D9242: Implemented support for hide/show groups.

It appears we still need to land D8855 first.

I do not think this is the problem since that after run: arc patch D9242. I got both changes on my tree.

I get:

$ arc patch D9242
 INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D9242.
 INFO  Base commit is not in local repository; trying to fetch.
Checking patch src/filewidgets/kfileplacesmodel.h...
error: src/filewidgets/kfileplacesmodel.h: does not exist in index
Checking patch src/filewidgets/kfileplacesmodel.cpp...
error: src/filewidgets/kfileplacesmodel.cpp: does not exist in index
Checking patch autotests/kfileplacesmodeltest.cpp...
error: autotests/kfileplacesmodeltest.cpp: does not exist in index

 Patch Failed! 
Usage Exception: Unable to apply patch!
Dec 8 2017, 7:05 PM
renatoo added a comment to D9242: Implemented support for hide/show groups.

It appears we still need to land D8855 first.

Dec 8 2017, 6:44 PM
renatoo added a comment to D9242: Implemented support for hide/show groups.

I can't apply this patch, can you please rebase it?

done

arc patch D9242 still doesn't work, looks like something else is missing.

Dec 8 2017, 6:43 PM
renatoo added a comment to D9242: Implemented support for hide/show groups.

I can't apply this patch, can you please rebase it?

Dec 8 2017, 5:05 PM
renatoo updated the diff for D9242: Implemented support for hide/show groups.

Rebased with master

Dec 8 2017, 5:05 PM
renatoo updated the diff for D8855: Use Kio::KPlacesModel as source model for PlacesItemModel.

Rebase with master

Dec 8 2017, 5:04 PM · Dolphin
renatoo updated the diff for D8855: Use Kio::KPlacesModel as source model for PlacesItemModel.

Removed override in favor of override

Dec 8 2017, 4:57 PM · Dolphin
renatoo added a comment to D9242: Implemented support for hide/show groups.

@elvisangelaccio ist that ok now?

Dec 8 2017, 1:50 PM
renatoo updated the diff for D9252: Created 'GroupHiddenRole' for KPlacesModel.

Refactored unit test

Dec 8 2017, 1:35 PM · Frameworks
renatoo updated the diff for D9242: Implemented support for hide/show groups.

Used new KFilePlacesModel::GroupHiddenRole to retrieve information instead of call the model method

Dec 8 2017, 1:26 PM
renatoo updated the summary of D9242: Implemented support for hide/show groups.
Dec 8 2017, 1:21 PM
renatoo added a dependent revision for D9252: Created 'GroupHiddenRole' for KPlacesModel: D9242: Implemented support for hide/show groups.
Dec 8 2017, 1:21 PM · Frameworks
renatoo updated the summary of D9252: Created 'GroupHiddenRole' for KPlacesModel.
Dec 8 2017, 1:21 PM · Frameworks
renatoo created D9252: Created 'GroupHiddenRole' for KPlacesModel.
Dec 8 2017, 1:20 PM · Frameworks

Dec 7 2017

renatoo updated the diff for D9241: Emit 'groupHiddenChanged' signal..

used static_cast<int>() for cast enums

Dec 7 2017, 3:08 PM · Frameworks
renatoo added a reviewer for D9241: Emit 'groupHiddenChanged' signal.: franckarrecot.
Dec 7 2017, 2:54 PM · Frameworks
renatoo added a reviewer for D9242: Implemented support for hide/show groups: franckarrecot.
Dec 7 2017, 2:53 PM
renatoo added a dependent revision for D8855: Use Kio::KPlacesModel as source model for PlacesItemModel: D9242: Implemented support for hide/show groups.
Dec 7 2017, 2:38 PM · Dolphin
renatoo updated the summary of D9242: Implemented support for hide/show groups.
Dec 7 2017, 2:38 PM
renatoo created D9242: Implemented support for hide/show groups.
Dec 7 2017, 2:38 PM
renatoo updated the summary of D9241: Emit 'groupHiddenChanged' signal..
Dec 7 2017, 2:28 PM · Frameworks
renatoo added a dependent revision for D8450: User can now hide an entire places group from KFilePlacesView: D9241: Emit 'groupHiddenChanged' signal..
Dec 7 2017, 2:28 PM · Frameworks
renatoo created D9241: Emit 'groupHiddenChanged' signal..
Dec 7 2017, 2:27 PM · Frameworks

Dec 6 2017

renatoo updated the diff for D8855: Use Kio::KPlacesModel as source model for PlacesItemModel.

Avoid crash while hiding a item.

Dec 6 2017, 3:30 PM · Dolphin
renatoo accepted D8450: User can now hide an entire places group from KFilePlacesView.

Looks good and work as expected

Dec 6 2017, 1:20 PM · Frameworks
renatoo accepted D8367: Hidding place groups implementation in KFilePlacesModel.

Looks good and works as expected

Dec 6 2017, 1:19 PM · Frameworks
renatoo added inline comments to D8855: Use Kio::KPlacesModel as source model for PlacesItemModel.
Dec 6 2017, 1:02 PM · Dolphin
renatoo updated the diff for D8855: Use Kio::KPlacesModel as source model for PlacesItemModel.

More fixes about rowCount usage

Dec 6 2017, 1:02 PM · Dolphin
renatoo added inline comments to D8855: Use Kio::KPlacesModel as source model for PlacesItemModel.
Dec 6 2017, 12:49 PM · Dolphin
renatoo updated the diff for D8855: Use Kio::KPlacesModel as source model for PlacesItemModel.

Used QVector insted of QList for m_indexMap

Dec 6 2017, 12:47 PM · Dolphin
renatoo updated the diff for D8855: Use Kio::KPlacesModel as source model for PlacesItemModel.

Avoid call model.rowCount() several times while on loop.

Dec 6 2017, 12:45 PM · Dolphin