Create 'KFilePlacesModel::convertedUrl' static function
ClosedPublic

Authored by renatoo on Nov 22 2017, 2:16 PM.

Details

Summary

Move convertedUrl from KFilePlacesView to KFilePlacesModel to be reused
by other views that use the same model.

Depends on D8332
Depends on D8434
Depends on D8348

Test Plan

unit test created

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
renatoo created this revision.Nov 22 2017, 2:16 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 22 2017, 2:16 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dfaure requested changes to this revision.Nov 22 2017, 2:49 PM
dfaure added inline comments.
src/filewidgets/kfileplacesmodel.h
137

You gave the search:/ url as an example of input, can you give an example of the corresponding output? I.e. add

(baloosearch, in this example)
140

it's not clear to me what the word "dynamic" means here.
Maybe just "the converted URL, which can be handled by an ioslave".

This revision now requires changes to proceed.Nov 22 2017, 2:49 PM
renatoo updated this revision to Diff 22755.Nov 22 2017, 5:23 PM
renatoo marked 2 inline comments as done.

Updated documentation

renatoo updated this revision to Diff 22766.Nov 22 2017, 5:57 PM

Updated parent branch

renatoo updated this revision to Diff 22778.Nov 22 2017, 7:15 PM

Updated from master

dfaure accepted this revision.Nov 22 2017, 10:16 PM
This revision is now accepted and ready to land.Nov 22 2017, 10:16 PM
renatoo updated this revision to Diff 22813.Nov 23 2017, 11:53 AM

Parent branch updated

renatoo updated this revision to Diff 22951.Nov 26 2017, 1:25 PM

Updated parent branch

renatoo updated this revision to Diff 22962.Nov 26 2017, 3:22 PM

Updated parent branch

renatoo updated this revision to Diff 23009.Nov 27 2017, 1:21 PM

Updated parent branch

Closed by commit R241:66682d0df7e6: Create 'KFilePlacesModel::convertedUrl' static function (authored by Renato Araujo Oliveira Filho <renato.araujo@kdab.com>). · Explain WhyNov 27 2017, 1:23 PM
This revision was automatically updated to reflect the committed changes.