with 'KFilePlacesModel::movePlace' the external APIs can easily move
items in the model without replicate the code.
Depends on D8947
Details
Details
Unit test created
Diff Detail
Diff Detail
- Repository
- R241 KIO
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/filewidgets/kfileplacesmodel.h | ||
|---|---|---|
| 80 | this doesn't match the names of the parameters, and use @p rather than single quotes. | |
| autotests/kfileplacesmodeltest.cpp | ||
|---|---|---|
| 1039 | typo: position | |
| 1041 | It was 0 already, so the TRY_ is unnecessary, if it's 0 it's ok right away, and if it's 1 then waiting more won't change it back to 0 ;) | |
| 1045 | remove TRY_ | |
| src/filewidgets/kfileplacesmodel.cpp | ||
| 635 | why not just if (target > source) ? You're not using direction anywhere else. | |
| 636 | Urgh, this shadows newTarget from the outer scope! | |
| 637 | missing space after while (repeats) | |
| 649 | typo: beginning | |