Differential D8947

Expose KFilePlacesModel 'iconName' role
ClosedPublic
Actions

Authored by renatoo on Nov 22 2017, 2:18 PM.

Tags

Subscribers

ngraham, kossebau, Frameworks

Details

Reviewers

Commits

R241:7be5649a0d9c: Expose KFilePlacesModel 'iconName' role

Summary

Make possible for external APIs to get the iconName used in each entry
of KFilePlacesModel

Depends on D8946

Test Plan

Unit test created

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

renatoo created this revision.Nov 22 2017, 2:18 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptNov 22 2017, 2:18 PM

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

renatoo mentioned this in D8862: Extend KFilePlacesModel API.Nov 22 2017, 2:21 PM

renatoo edited the summary of this revision. (Show Details)Nov 22 2017, 2:26 PM

renatoo added a reviewer: dfaure.

renatoo added a dependency: D8946: Avoid unnecessary 'dataChanged' signal.

renatoo added a dependent revision: D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'.

dfaure accepted this revision.Nov 22 2017, 3:12 PM

This revision is now accepted and ready to land.Nov 22 2017, 3:12 PM

kossebau added a subscriber: kossebau.Nov 22 2017, 3:46 PM

kossebau added inline comments.

src/filewidgets/kfileplacesmodel.h
52	+1 for adding `@since`. But needs three slashes`///` for doxygen to pick up this comment

ngraham added a subscriber: ngraham.Nov 22 2017, 4:04 PM

renatoo retitled this revision from Expose KFilePlacesModel 'iconName' rule to Expose KFilePlacesModel 'iconName' role.Nov 22 2017, 5:21 PM

Updated documentation

Updated parent branch

Updated from master

Parent branch updated

Updated parent branch

Updated parent branch

franckarrecot added a dependent revision: D8367: Hidding place groups implementation in KFilePlacesModel.Nov 27 2017, 11:16 AM

franckarrecot added a dependent revision: D8450: User can now hide an entire places group from KFilePlacesView.Nov 27 2017, 11:19 AM

Updated parent branch

Closed by commit R241:7be5649a0d9c: Expose KFilePlacesModel 'iconName' role (authored by Renato Araujo Oliveira Filho <renato.araujo@kdab.com>). · Explain WhyNov 27 2017, 1:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/kfileplacesmodeltest.cpp (34 lines)
M			src/filewidgets/kfileplacesitem.cpp (5 lines)
M			src/filewidgets/kfileplacesmodel.h (4 lines)

Diff 23019

autotests/kfileplacesmodeltest.cpp

Loading...

src/filewidgets/kfileplacesitem.cpp

Loading...

src/filewidgets/kfileplacesmodel.h

Loading...