The mockups look very nice :)

can we fix this and go ahead?
@mbruchert can you still work on it? want to put it on invent?

couldn't also gridThickness automatically scale itself without having to expose it to the user?

please use gitlab on invent.kde.org for new review requests

yes please on gitlab.
are you sure you don't get double painting on opengl now?

• update to new colors

looks good

the length of that button text is quite daunting, i fear imagining how would be in geman :p

this needs dependency upon Qt 5.15, right?

what should happen in this case?

can you add an example about it in /examples ?

In D29462#668542, @mart wrote:

the different Units.qml depend from the style, QT_QUICK_CONTROLS_STYLE
all of them, including those in plasma-framework should be updated at once

I would like this class to be splitted in Templates/controls, so different styles could make it look slightly sifferent (or anyways easier for the app developer to make one that looks just slightly different)
the root component should be a Control, with image/icon/initials in contentItem and background collor/border in background
the one in templates would not have a background the one in controls would instantiate the one in templates and give it one.

hmm, should probably check before whether systemsettings5 and kinfocenter exist beforehand and fallback to kcmshell if not?

In D29765#671426, @filipf wrote:

I'm not keen on duplicating the entire theme for a single option.

I would also prefer to just have it as an option, but turning off blur requires several workarounds to ensure legibility.

yes, that screenshot is really broken.
to me is important that the tabbar tries to take all the space available before doing any eliding.
Probably whether starting to elide a lot and make the tabs actually scrollable, will depend case by case depending fro mthe app

If i make the window narrow enough, that's what happens