Check if the clipboard is empty when initializing the status of the Clipboard applet
ClosedPublic

Authored by epopov on Tue, May 19, 9:54 AM.

Details

Summary

In D29652, I made an annoying mistake: I removed the check if the clipboard is empty when initializing the Plasmoid.status of the Clipboard applet. If the user enables the option to save clipboard content, then after restarting the Plasma, even if the clipboard had content, the state of the applet will be PlasmaCore.Types.PassiveStatus and its icon will be hidden in the system tray. This patch fixes this issue. I hope it will get into Plasma 5.19.

See: https://phabricator.kde.org/D29652

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
epopov created this revision.Tue, May 19, 9:54 AM
Restricted Application added a project: Plasma. · View Herald TranscriptTue, May 19, 9:54 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
epopov requested review of this revision.Tue, May 19, 9:54 AM
mart accepted this revision.Tue, May 19, 10:38 AM
This revision is now accepted and ready to land.Tue, May 19, 10:38 AM
ngraham accepted this revision.Tue, May 19, 2:31 PM

Oops, sorry for not catching that. D29652 was landed on master, not 5.19, so it's not urgent. Thanks.

Note that we have migrated to GitLab; would you mind submitting future patches as Merge Requests at https://invent.kde.org? See also https://community.kde.org/Infrastructure/GitLab

ngraham closed this revision.Tue, May 19, 3:04 PM

was landed on master, not 5.19

Can it be moved to Plasma 5.19?

was landed on master, not 5.19

Can it be moved to Plasma 5.19?

Rut the regression isn't on 5.19 because it was introduced in D29652, which is not in 5.19.

Right?

epopov added a comment.EditedTue, May 19, 4:28 PM

Right, but they can be cherry-picked to the Plasma 5.19. In truth, I'm tired of editing these files after every Plasma update☹️

Oh you mean both of them. Yeah, seems reasonable.

Ah, it doesn't cherry-pick cleanly. You'll have to wait for 5.20, sorry. This is a good incentive to start living on git master. :)

Ohhh, okay, thanks anyway😢