| ngraham |
Before these changes grid took a lot of space, especially for smaller taskbars. Even with grid disabled there were big spaces between squares that was not used. Now users can decrease grid thickness which will increase squares size making the clock bigger and easier to read.
| No Linters Available |
| No Unit Test Coverage |
| Buildable 27105 | |
| Build 27123: arc lint + arc unit |
This is probably the last diff from my initial Binary Clock rework from D13937.
If you have any ideas what else can be improved after these changes, please let me know.
@ngraham It does scale smooth-ish-ly according to taskbar size. You can see that square size (dotSize in BinaryClock.qml) is calculated based on taskbar size (height for horizontal taskbar and width for vertical taskbar). When you change taskbar size, binary clock changes size as well.
couldn't also gridThickness automatically scale itself without having to expose it to the user?
I logged in on that page and I don't know what to do. Why don't I just add reviewers from my previous Binary Clock widget diffs?
It could be done in another diff as it's another functionality. However, I would need to think of a formula that would do it. Because when you have fixed taskbar height and border thickness you can calculate square size (which is how it works after this diff), when you have fixed height and square size you can calculate border thickness (which is inferior idea imo). But given taskbar height, to calculate both square size and border thickness you would need to know the ratio between them or ratio on of them to the taskbar size. And I don't know how to choose the best ratio that is not arbitrary.