Feed Advanced Search

May 13 2020

mart committed R1049:0be7ad0d51ab: guard model behind a QPointer (authored by mart).
guard model behind a QPointer
May 13 2020, 5:34 PM
mart committed R1049:789dbfbc9224: fix infinite recursion (authored by mart).
fix infinite recursion
May 13 2020, 5:34 PM
mart committed R111:b2a04aa30c79: proper color source (authored by mart).
proper color source
May 13 2020, 2:34 PM
mart committed R111:ee2ff95bcbab: support translations in faces (authored by mart).
support translations in faces
May 13 2020, 2:32 PM
mart closed D29706: support translations in faces.
May 13 2020, 2:32 PM · Plasma
mart updated the diff for D29706: support translations in faces.
  • i18nd
May 13 2020, 2:18 PM · Plasma
mart updated the diff for D29706: support translations in faces.
  • add own context for the internal qml files
May 13 2020, 2:13 PM · Plasma
mart added a comment to D29706: support translations in faces.

Who extracts and loads the translations for:

./ConfigAppearance.qml
./ConfigSensors.qml
./FaceDetailsConfig.qml
./UsedSensorsView.qml

in the top level of faces but not in an individual package.

May 13 2020, 2:03 PM · Plasma
mart requested review of D29706: support translations in faces.
May 13 2020, 12:29 PM · Plasma

May 12 2020

mart committed R120:6f6c73394358: sync formfactor from plasmoid to faces (authored by mart).
sync formfactor from plasmoid to faces
May 12 2020, 5:15 PM
mart committed R111:cd8351b53f93: fix SensorFaceController::compactRepresentation() (authored by mart).
fix SensorFaceController::compactRepresentation()
May 12 2020, 5:01 PM
mart accepted D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout.
May 12 2020, 4:47 PM · Plasma
mart updated the diff for D29637: Introduce ImageColors.
  • adress feedbacks
May 12 2020, 9:37 AM · Kirigami

May 11 2020

mart accepted D29544: [applets/systemtray] Show base icon when AttentionIcon not set.
May 11 2020, 4:02 PM · Plasma
mart added a comment to D29535: Add a SpinBox (with draggability) to panel thickness adjustment UI.

Sorry, i don't think it's the right path, for several reasons,

  • The spinbox look is different from the desktop one, better or worse is secondary, but it's actually a sore point of the plasma theme at the moment :/
  • It exposes very directly pixel numbers in the ui, unless it's a graphic application, i hate when it happens in an ui and in our software happens too much (and no, no user should ever be asked to know what a pixel is)
  • it keeps the window still when the panel resizes, looking kinda broken, but worse, making even possible for the panel to cover up the spinbox itself
May 11 2020, 4:02 PM · Plasma
mart added a comment to D29535: Add a SpinBox (with draggability) to panel thickness adjustment UI.

-1 :(

May 11 2020, 3:54 PM · Plasma
mart accepted D29625: Add global shortcut.
May 11 2020, 3:53 PM · Plasma
mart accepted D29579: [kcms/keys] Really ignore unknown action.
May 11 2020, 3:51 PM · Plasma
mart accepted D29548: Drag and drop assigning windows to activities in the default switcher.

What Nate says, after that go for it

May 11 2020, 3:51 PM · Plasma
mart accepted D29633: [Battery Monitor] Fix toolTipMainText when plugged in.
May 11 2020, 3:46 PM · Plasma
mart accepted D29644: Select application after it is added.
May 11 2020, 3:43 PM · Plasma
mart accepted D29288: Improve PageRouter API.
May 11 2020, 3:41 PM · Kirigami
mart added a comment to D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi.

the different Units.qml depend from the style, QT_QUICK_CONTROLS_STYLE
all of them, including those in plasma-framework should be updated at once

May 11 2020, 3:40 PM · Kirigami
mart updated the test plan for D29637: Introduce ImageColors.
May 11 2020, 3:08 PM · Kirigami
mart requested review of D29637: Introduce ImageColors.
May 11 2020, 3:06 PM · Kirigami
mart committed R169:63132365bcc9: move lab conversion on own function (authored by mart).
move lab conversion on own function
May 11 2020, 2:50 PM
mart closed D28922: Port Sensor Face loading from plasmoid.
May 11 2020, 11:13 AM · Plasma
mart committed R120:c8deafbb0731: Redesign of system monitor plasmoids (authored by mart).
Redesign of system monitor plasmoids
May 11 2020, 11:09 AM
mart closed D28487: Redesign of system monitor plasmoids.
May 11 2020, 11:09 AM · Plasma
mart committed R111:cc789f3ac12b: Add KSysGuard::Sensors library (authored by mart).
Add KSysGuard::Sensors library
May 11 2020, 9:38 AM
mart closed D29157: force systemsettings for kcms.
May 11 2020, 8:41 AM · Plasma
mart committed R120:e67e8d6d92a1: force systemsettings for kcms (authored by mart).
force systemsettings for kcms
May 11 2020, 8:41 AM
mart committed R124:c3debf5fe0f2: Support module commandline paramenter (authored by mart).
Support module commandline paramenter
May 11 2020, 8:40 AM
mart closed D29064: Support module commandline paramenter.
May 11 2020, 8:40 AM · Plasma

May 8 2020

mart updated the diff for D28922: Port Sensor Face loading from plasmoid.
  • Merge branch 'sensors_lib' into mart/sensor_face
May 8 2020, 4:40 PM · Plasma
mart updated the diff for D28487: Redesign of system monitor plasmoids.
  • Merge branch 'master' into mart/mewSystemMonitor
May 8 2020, 4:35 PM · Plasma
mart updated the diff for D29157: force systemsettings for kcms.
  • infocenter modules in own category
May 8 2020, 4:17 PM · Plasma
mart updated the diff for D29157: force systemsettings for kcms.
  • use kinfocenter for kinfocenter modules
May 8 2020, 4:12 PM · Plasma
mart updated the diff for D28922: Port Sensor Face loading from plasmoid.
  • sensorColors is now a map
  • fix preset uninstall
May 8 2020, 3:52 PM · Plasma
mart committed R111:5c0d34d98790: fix preset uninstall (authored by mart).
fix preset uninstall
May 8 2020, 3:52 PM
mart committed R111:e377696e2851: sensorColors is now a map (authored by mart).
sensorColors is now a map
May 8 2020, 3:18 PM
mart accepted D29527: Add MapProxySource.

works perfectly :)

May 8 2020, 2:35 PM · Frameworks

May 7 2020

mart committed R120:b518e1d4fdfb: adapt to api changes (authored by mart).
adapt to api changes
May 7 2020, 5:11 PM
mart updated the diff for D28487: Redesign of system monitor plasmoids.
  • adapt to api changes
May 7 2020, 5:11 PM · Plasma
mart updated the diff for D28922: Port Sensor Face loading from plasmoid.
  • use QJsonArrays for sensors
May 7 2020, 5:10 PM · Plasma
mart committed R111:8c57f407dd4d: use QJsonArrays for sensors (authored by mart).
use QJsonArrays for sensors
May 7 2020, 5:10 PM
mart added inline comments to D29288: Improve PageRouter API.
May 7 2020, 1:49 PM · Kirigami
mart updated the diff for D28922: Port Sensor Face loading from plasmoid.
  • remove extra debug
May 7 2020, 10:16 AM · Plasma
mart committed R111:0f0e7dbb57a4: remove extra debug (authored by mart).
remove extra debug
May 7 2020, 10:16 AM
mart committed R120:897b458543b9: make disk usage a bar chart (authored by mart).
make disk usage a bar chart
May 7 2020, 10:08 AM
mart updated the diff for D28487: Redesign of system monitor plasmoids.
  • make disk usage a bar chart
May 7 2020, 10:07 AM · Plasma
mart updated the diff for D28922: Port Sensor Face loading from plasmoid.
  • use regexp for multiple sensors
  • left-alignlegends when they are too wide
May 7 2020, 10:04 AM · Plasma
mart committed R111:ac235c5f8248: left-alignlegends when they are too wide (authored by mart).
left-alignlegends when they are too wide
May 7 2020, 10:04 AM
mart committed R111:b384cd2dc1b6: use regexp for multiple sensors (authored by mart).
use regexp for multiple sensors
May 7 2020, 10:04 AM
mart committed R111:89c191d7431a: add space (authored by mart).
add space
May 7 2020, 10:04 AM

May 6 2020

mart updated the diff for D28922: Port Sensor Face loading from plasmoid.
  • add space
May 6 2020, 4:05 PM · Plasma
mart updated the diff for D28487: Redesign of system monitor plasmoids.
  • Controls QQC2
May 6 2020, 4:03 PM · Plasma
mart committed R120:003c6a1d8460: Controls QQC2 (authored by mart).
Controls QQC2
May 6 2020, 4:03 PM
mart updated the diff for D28487: Redesign of system monitor plasmoids.
  • adapt to api changes
  • move faces config in own file
May 6 2020, 3:59 PM · Plasma
mart updated the diff for D28922: Port Sensor Face loading from plasmoid.
  • move face properties in own file
  • move face config in own file
May 6 2020, 3:55 PM · Plasma
mart committed R120:d5bf4e3fe3e2: move faces config in own file (authored by mart).
move faces config in own file
May 6 2020, 3:55 PM
mart committed R111:7f506344671c: move face config in own file (authored by mart).
move face config in own file
May 6 2020, 3:52 PM
mart committed R111:7da4b8346252: SupportsTotalSensor->SupportsTotalSensors (authored by mart).
SupportsTotalSensor->SupportsTotalSensors
May 6 2020, 2:44 PM
mart committed R111:fe8a62f5043d: move face properties in own file (authored by mart).
move face properties in own file
May 6 2020, 2:44 PM
mart updated the diff for D28922: Port Sensor Face loading from plasmoid.
  • default to linechart
  • default to textonly
  • sensorIds highPrioritySensorIds
  • kill table visualization
  • TotalSensor->TotalSensors list
  • SupportsTotalSensor->SupportsTotalSensors
May 6 2020, 1:08 PM · Plasma
mart committed R111:0ca082f6e721: TotalSensor->TotalSensors list (authored by mart).
TotalSensor->TotalSensors list
May 6 2020, 1:02 PM
mart committed R111:2791345bdce7: kill table visualization (authored by mart).
kill table visualization
May 6 2020, 10:32 AM

May 5 2020

mart committed R120:5e35386ea44e: adapt to api changes (authored by mart).
adapt to api changes
May 5 2020, 4:34 PM
mart committed R111:dcae6558b779: sensorIds highPrioritySensorIds (authored by mart).
sensorIds highPrioritySensorIds
May 5 2020, 4:33 PM
mart committed R111:69e02c92ca34: default to textonly (authored by mart).
default to textonly
May 5 2020, 4:33 PM
mart added a comment to T10034: Attract existing FLOSS software projects to KDE and incorporate their members into our community.

May I add a question here, a bit offtopic? It appeared to me that there is a general trend towards QtQuick because a) it looks great and b) tends to be touch and mobile friendly. While I disagree with a, I wonder whether an inherently complex UI like that of FreeCad would benefit from b. KXmlGui is great for customizing the toolbars and QDockWidgets are nice to rearrange the UI components on the screen. While I have nothing to say about the technical implemenation, would/could these features (which FreeCAD already has) be kept with QtQuick?

May 5 2020, 3:29 PM · KDE Promo

May 4 2020

mart accepted D29294: Add support for layers to PagePoolAction..
May 4 2020, 6:56 PM · Kirigami
mart added inline comments to D28922: Port Sensor Face loading from plasmoid.
May 4 2020, 4:24 PM · Plasma
mart added a comment to T10034: Attract existing FLOSS software projects to KDE and incorporate their members into our community.

To cut to the chase, it seems like a technological leapfrogging would be possible by making a proof-of-concept Kirigami-based FreeCAD UI, and once it's been shown to be possible, the rest should follow. I think the "sell" to our community of leaning on KDE for UI/UX expertise and letting CAD programmers work on CAD instead should be pretty easy and outweigh possible packaging pain.

May 4 2020, 3:59 PM · KDE Promo
mart accepted D29412: Add smallFont to Kirigami plasma style.
May 4 2020, 2:30 PM · Frameworks
mart committed R111:9f0ff2d78b24: default to linechart (authored by mart).
default to linechart
May 4 2020, 1:54 PM
mart committed R111:096ef05ab9af: adress a part of comments (authored by mart).
adress a part of comments
May 4 2020, 1:48 PM
mart added inline comments to D28922: Port Sensor Face loading from plasmoid.
May 4 2020, 1:24 PM · Plasma
mart updated the diff for D28922: Port Sensor Face loading from plasmoid.
  • start to port other faces
  • port faces to new api
  • add missing file
  • adapt to api changes
  • adress a part of comments
May 4 2020, 1:24 PM · Plasma
mart accepted D28333: Add a new daemon for stats monitoring.
May 4 2020, 12:14 PM · Plasma
mart accepted D28888: Fix navigation regressions.
May 4 2020, 12:05 PM · Kirigami, Plasma
mart accepted D29222: Fix update auto selection.
May 4 2020, 10:32 AM · Frameworks
mart accepted D28701: Add KPackage support to KNewStuffCore.
May 4 2020, 10:29 AM · Frameworks
mart added a comment to D29312: Change microphoneindicator for reporting audio monitors.

i think i would prefer a somewhat inaccurate message, rather than an obscuretecnicism which is technically accurate (

May 4 2020, 10:01 AM · Plasma
mart accepted D29307: Implement smallFont in Kirigami plugin.
May 4 2020, 9:59 AM · Plasma
mart accepted D29315: [applets/batterymonitor] Port inhibition message to Layouts and match notifications applet.
May 4 2020, 9:56 AM · Plasma
mart added a comment to D29324: [Network Monitor] Show correct bitrate.

note that there is a whole rewrite pending for all systemmonitor applets in D28487 (and several related diffs)

May 4 2020, 9:55 AM · Plasma
mart accepted D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added.
May 4 2020, 9:42 AM · Plasma
mart requested changes to D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout.

unfortunately yeah, i had to port away from opacityanimator several places for this reason :(

May 4 2020, 9:23 AM · Plasma
mart added a comment to D29366: [Wallpaper Configuration] Reword inline message concerning widget locking.

Ok, so the message can indeed still be turned on.

Setting:
~/.config/plasmarc [General] immutability=2 (or 4)

... does not work, however the following does:

~/.config/kdeglobals [KDE Action Restrictions][$i] plasma/plasmashell/unlockedDesktop=false

Which means that if widget locking now only exists as a restriction... perhaps it would make more sense to change the text of this inline message to say "Layout changes have been restricted by the system administrator"?

yeah, +1 for that

May 4 2020, 9:18 AM · Plasma
mart accepted D29379: Unassign activity from vault on activity deletion.
May 4 2020, 9:13 AM · Plasma
mart added a comment to D29201: KCMUtils: Add option to append service file to list of arguments.

indeed, a bit more documentation then go for it

May 4 2020, 9:13 AM · Frameworks
mart accepted D29106: Introduce RouterWindow control.
May 4 2020, 9:10 AM · Kirigami
mart accepted D29046: ColorUtils: Use const ref for QColor/QJSValue, fix code style.
May 4 2020, 9:08 AM · Kirigami

Apr 30 2020

mart accepted D29304: Introduce Theme::smallFont.
Apr 30 2020, 4:35 PM · Kirigami
mart added inline comments to D29304: Introduce Theme::smallFont.
Apr 30 2020, 4:35 PM · Kirigami
mart committed R169:e5ca5c91a9d9: use lab chroma for finding highlight (authored by mart).
use lab chroma for finding highlight
Apr 30 2020, 3:19 PM
mart committed R169:261ef86f1a96: documentation++ (authored by mart).
documentation++
Apr 30 2020, 3:19 PM
mart accepted D29074: Make BasicListItem more useful by giving it a subtitle property.
Apr 30 2020, 3:18 PM · Kirigami
mart added inline comments to D29074: Make BasicListItem more useful by giving it a subtitle property.
Apr 30 2020, 2:51 PM · Kirigami