support translations in faces
ClosedPublic

Authored by mart on May 13 2020, 12:29 PM.

Details

Summary

give each face its own catalog

Diff Detail

Repository
R111 KSysguard Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.May 13 2020, 12:29 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 13 2020, 12:29 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.May 13 2020, 12:29 PM

Who extracts and loads the translations for:

./ConfigAppearance.qml
./ConfigSensors.qml
./FaceDetailsConfig.qml
./UsedSensorsView.qml

in the top level of faces but not in an individual package.


code for the other stuff looks correct.

mart added a comment.May 13 2020, 2:03 PM

Who extracts and loads the translations for:

./ConfigAppearance.qml
./ConfigSensors.qml
./FaceDetailsConfig.qml
./UsedSensorsView.qml

in the top level of faces but not in an individual package.

right, messages.sh will have to extract from qml as well (and on those files i18nc to be used with an explicitly defined context)

mart updated this revision to Diff 82741.May 13 2020, 2:13 PM
  • add own context for the internal qml files
mart updated this revision to Diff 82743.May 13 2020, 2:18 PM
  • i18nd
davidedmundson accepted this revision.May 13 2020, 2:19 PM
This revision is now accepted and ready to land.May 13 2020, 2:19 PM
This revision was automatically updated to reflect the committed changes.