Differential D29157

force systemsettings for kcms
ClosedPublic
Actions

Authored by mart on Apr 24 2020, 4:59 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R120:e67e8d6d92a1: force systemsettings for kcms
Summary

as we can't kill completely kcmshell just yet, hack intothe services runner to
replace on the fly the exec line of the service to systemsettings

BUG: 402790
FIXED-IN: 5.19.0

Test Plan

search and launch directly for a module, systemsettings is launched wit hthe
proper module loaded

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Apr 24 2020, 4:59 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 24 2020, 4:59 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Apr 24 2020, 4:59 PM
davidre added a subscriber: davidre.Apr 24 2020, 5:23 PM

Maybe todo remove?

ngraham added a subscriber: ngraham.EditedApr 24 2020, 5:39 PM

Heh, clever!

However if System Settings is already open and you use KRunner to open a KCM, it switches focus to that existing System Settings window but doesn't show you the thing that you just opened.

broulik added a subscriber: broulik.Apr 27 2020, 7:13 AM

+1

runners/services/servicerunner.cpp
465

A comment here would be nice

mart added a comment.Apr 27 2020, 9:47 AM
In D29157#656640, @ngraham wrote:

Heh, clever!

However if System Settings is already open and you use KRunner to open a KCM, it switches focus to that existing System Settings window but doesn't show you the thing that you just opened.

new version of D29064 makes systemsettings load the new kcm

mart updated this revision to Diff 81320.Apr 27 2020, 9:55 AM
  • comments++
mart marked an inline comment as done.Apr 27 2020, 9:55 AM
mart marked an inline comment as not done.Apr 27 2020, 11:12 AM
mart marked an inline comment as done.
ngraham accepted this revision.Apr 27 2020, 3:11 PM
This revision is now accepted and ready to land.Apr 27 2020, 3:11 PM
ngraham edited the summary of this revision. (Show Details)Apr 27 2020, 3:11 PM
ngraham requested changes to this revision.Apr 27 2020, 8:59 PM

Looks like this also needs to invoke kinfocenter mode when needed. If I search for "energy" from KRunner now, it opens Systemsettings with the home page visible, not the Energy Consumption Statistics KCM.

This revision now requires changes to proceed.Apr 27 2020, 8:59 PM
mart updated this revision to Diff 82282.May 8 2020, 4:12 PM
  • use kinfocenter for kinfocenter modules
ngraham accepted this revision.May 8 2020, 4:16 PM
This revision is now accepted and ready to land.May 8 2020, 4:16 PM
mart updated this revision to Diff 82283.May 8 2020, 4:17 PM
  • infocenter modules in own category
ngraham accepted this revision.May 8 2020, 4:19 PM

I say ship it!

Closed by commit R120:e67e8d6d92a1: force systemsettings for kcms (authored by mart). · Explain WhyMay 11 2020, 8:41 AM
This revision was automatically updated to reflect the committed changes.
davidedmundson added a subscriber: davidedmundson.May 12 2020, 9:09 PM

We need a fix for https://bugs.kde.org/show_bug.cgi?id=421431

Which could just be me removing making it hidden.

Revision Contents
Changeset List

PathPackages
Mrunners/services/servicerunner.cpp (17 lines)

Diff 82498

View Options

runners/services/servicerunner.cpp

Loading...