- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Feb 27 2020
Looking good.
Jan 7 2020
Do you mean this "if ()" part of code? If there is no style "graphic" and inner "if" will not execute. Do you mean it'll be better to handle it in this part of code...or what?
loadTableCellProperties() is a method for applying styles for table cells, i.e. cell background. There is no handling for cell background in the place you mentioned.
Jan 3 2020
Don't know this shape stuff that well, but text shape plugin handling custom-shape feels suspicious.
Not sure about all the details but two things look suspicious here:
Actually seems to now revert that one line as it was before commit fc7b878f206fb / https://bugs.kde.org/show_bug.cgi?id=306141
Dec 31 2019
Seems to work and big impact indeed. Approving already.
Dec 30 2019
Dec 10 2019
Dec 3 2019
Nov 29 2019
Nov 26 2019
Or in other words: support for escaped brackets \{ \}
Nov 21 2019
A bit mixed feelings for this. In a way nice to avoid unnecessary work, but then again it seems effectively a compilation option if xlsx support is for read-write or view-only. On main level CMake it's also a bit random detail compared to others.
Nov 20 2019
Nov 19 2019
Nov 14 2019
Seems reasonable to me. I'll approve later if no-one objects.
Seems reasonable to me.
Nov 13 2019
Nov 11 2019
Nov 8 2019
But would those characters work without encoding adjustments if the used MS font was present? Not sure how it gets rendered now without the font, but if it's anything like the "J" exchange email smiley I'm not sure which is worse.
Nov 7 2019
Is there something in the spec encoding the microsoft fonts or just some kind of practice? Seems a little scary just stripping bits.
Minor comment, but overall looks good to me.
Seems sensical for what I can tell. I'll do some test round and (likely) approve later if no objections pop up.
Nov 6 2019
Seems sensible to me. I'll approve and merge shortly if no-one objects.
Seems good.
Seems good.
Looks good to me.
Nov 1 2019
Oct 31 2019
Haven't looked and to be honest a little skeptical if anyone removing a null check is likely enough to protect against.
Looks good to me.
Also remove the empty target file on error
Oct 30 2019
Oct 29 2019
Update image size reading conditions
Oct 28 2019
Whitespace adjustments
Oct 25 2019
Seems it was indeed the only physicalDpi, though not too many logical either. Not trivial to follow, but seems sane and the screenshots are thorough. I'll approve if no-one objects shortly.
Oct 22 2019
Looking good to me.
Oct 21 2019
Oct 17 2019
Sep 2 2019
And even rendering now better, no idea what happened.
Having a bit strange rendering for TextDocumentImpl.cpp changes here, but the raw diff looks good now. Trust all good :)
Aug 30 2019
Indeed that doesn't look like a good loop, if triggered once, nothing affecting the break out condition inside of it. But isn't the same thing happening also at the beginning of this method, and actually same kind of construct being there in spreadsheet and presentation impls too?
Apr 26 2019
Second ping for this.