Fix null pointer reference when extraction fails
ClosedPublic

Authored by pvuorela on Oct 17 2019, 10:28 AM.

Diff Detail

Repository
R243 KArchive
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
pvuorela created this revision.Oct 17 2019, 10:28 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 17 2019, 10:28 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
pvuorela requested review of this revision.Oct 17 2019, 10:28 AM
pvuorela updated this revision to Diff 69086.Oct 31 2019, 8:37 AM

Also remove the empty target file on error

apol added a subscriber: apol.Oct 31 2019, 1:40 PM

Have you looked into creating a unit test for this?

Haven't looked and to be honest a little skeptical if anyone removing a null check is likely enough to protect against.

aacid accepted this revision.Oct 31 2019, 8:53 PM
This revision is now accepted and ready to land.Oct 31 2019, 8:53 PM
This revision was automatically updated to reflect the committed changes.