Differential D24830

Add support for strikeout text in RTF documents
ClosedPublic
Actions

Authored by akomakhin on Oct 21 2019, 1:57 PM.

Details

Reviewers
pvuorela
Group Reviewers
Calligra: 3.0
Commits
R8:11b3b7718796: Add support for strikeout text in RTF documents

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
akomakhin created this revision.Oct 21 2019, 1:57 PM
Restricted Application added a project: Calligra: 3.0. · View Herald TranscriptOct 21 2019, 1:57 PM
Restricted Application added a subscriber: Calligra-Devel-list. · View Herald Transcript
akomakhin requested review of this revision.Oct 21 2019, 1:57 PM
pvuorela added inline comments.Oct 21 2019, 2:12 PM
filters/words/rtf/import/3rdparty/rtf-qt/src/DocumentDestination.cpp
121

Value should be like bold and underline, i.e. something like "! hasValue || ( hasValue && value != 0 )" ?

akomakhin updated this revision to Diff 68442.Oct 21 2019, 2:27 PM

Fixed set value from "true" to expression " ! hasValue || ( hasValue && value != 0 ) "

akomakhin marked an inline comment as done.Oct 21 2019, 2:28 PM
boemann added a subscriber: boemann.Oct 21 2019, 2:49 PM

As far as I'm concerned you may push to rtf importer at your own discretion

pvuorela accepted this revision.Oct 22 2019, 8:15 AM

Looking good to me.

This revision is now accepted and ready to land.Oct 22 2019, 8:15 AM
Closed by commit R8:11b3b7718796: Add support for strikeout text in RTF documents (authored by pvuorela). · Explain WhyOct 22 2019, 9:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 68516

View Options

filters/words/rtf/import/3rdparty/rtf-qt/src/AbstractRtfOutput.h

Loading...
View Options

filters/words/rtf/import/3rdparty/rtf-qt/src/DocumentDestination.cpp

Loading...
View Options

filters/words/rtf/import/3rdparty/rtf-qt/src/TextDocumentRtfOutput.h

Loading...
View Options

filters/words/rtf/import/3rdparty/rtf-qt/src/TextDocumentRtfOutput.cpp

Loading...