Don't allow an unrecognized child element to block loading of a shape plugin.
ClosedPublic

Authored by denexter on Tue, Oct 29, 6:08 AM.

Details

Summary

If an object element has child elements but no shape plugin can be resolved for any of them fall back to trying to create a plugin from the root element.

This guards against cases like the snippet below where an experimental tag has been embedded in an element which would have otherwise correctly loaded the charts plugin.

<draw:object draw:notify-on-update-of-ranges="Лист1.B2:Лист1.B12" xlink:href="./Object 1" xlink:type="simple" xlink:show="embed" xlink:actuate="onLoad">

<loext:p />

</draw:object>

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
denexter created this revision.Tue, Oct 29, 6:08 AM
Restricted Application added a project: Calligra: 3.0. · View Herald TranscriptTue, Oct 29, 6:08 AM
Restricted Application added a subscriber: Calligra-Devel-list. · View Herald Transcript
denexter requested review of this revision.Tue, Oct 29, 6:08 AM

Seems sensible to me. I'll approve and merge shortly if no-one objects.

pvuorela accepted this revision.Mon, Nov 11, 8:49 AM
This revision is now accepted and ready to land.Mon, Nov 11, 8:49 AM
This revision was automatically updated to reflect the committed changes.