Extract images from excel files which omit the FtCF entry.
ClosedPublic

Authored by denexter on Tue, Oct 29, 6:34 AM.

Details

Summary

The specification says it and the flags entry must exist if the object type is picture but appears to not be true of some files. Since there's no essential information there add a basic check for the field id and if it not what is expected skip parsing of that field without invalidating the entire object.

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
denexter created this revision.Tue, Oct 29, 6:34 AM
Restricted Application added a project: Calligra: 3.0. · View Herald TranscriptTue, Oct 29, 6:34 AM
Restricted Application added a subscriber: Calligra-Devel-list. · View Herald Transcript
denexter requested review of this revision.Tue, Oct 29, 6:34 AM
pvuorela accepted this revision.Thu, Nov 7, 9:48 AM

Minor comment, but overall looks good to me.

filters/sheets/excel/sidewinder/excel.cpp
1421

Minor, but this line can be removed now?

This revision is now accepted and ready to land.Thu, Nov 7, 9:48 AM
This revision was automatically updated to reflect the committed changes.