Fix incorrect conditional styling of spreadsheet cells.
ClosedPublic

Authored by denexter on Tue, Oct 29, 6:58 AM.

Details

Summary

Include the conditions default style when comparing equality and calculating the hash to reduce instances of false equivalency.

Then remove the QMap index cache since sorting on a hash an item may still produce unstable results in the somewhat unlikely case of a hash collision and it's going to take a lot of items before building and searching the map starts to be less expensive than a linear scan.

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
denexter created this revision.Tue, Oct 29, 6:58 AM
Restricted Application added a project: Calligra: 3.0. · View Herald TranscriptTue, Oct 29, 6:58 AM
Restricted Application added a subscriber: Calligra-Devel-list. · View Herald Transcript
denexter requested review of this revision.Tue, Oct 29, 6:58 AM
pvuorela accepted this revision.Wed, Nov 6, 1:15 PM

Looks good to me.

This revision is now accepted and ready to land.Wed, Nov 6, 1:15 PM
This revision was automatically updated to reflect the committed changes.