Remove unsupported attributes from QGraphicsWidgets
Needs ReviewPublic

Authored by pvuorela on Mar 14 2019, 2:42 PM.



Qt::WA_InputMethodEnabled and WA_StaticContents attributes
are only supported by QWidget, not QGraphicsWidget.
Resulted warnings like
"QGraphicsWidget::setAttribute: unsupported attribute 14".

Don't think this has ever worked as intended.

Diff Detail

R8 Calligra
Lint Skipped
Unit Tests Skipped
pvuorela created this revision.Mar 14 2019, 2:42 PM
Restricted Application added a project: Calligra: 3.0. · View Herald TranscriptMar 14 2019, 2:42 PM
Restricted Application added a subscriber: Calligra-Devel-list. · View Herald Transcript
pvuorela requested review of this revision.Mar 14 2019, 2:42 PM
pvuorela updated this revision to Diff 54325.Mar 19 2019, 3:03 PM
pvuorela retitled this revision from Remove Qt::WA_InputMethodEnabled attribute from QGraphicsWidgets to Remove unsupported attributes from QGraphicsWidgets.
pvuorela edited the summary of this revision. (Show Details)

Updated to remove also WA_StaticContents in addition to earlier WA_InputMethodEnabled.

Ping, how about this one? The behavior change, or lack of it, should be mostly visible around qgraphicswidget_p.h -> attributeToBitIndex() & setAttribute().

Second ping for this.