Feed Advanced Search

Jul 12 2017

zhigalin accepted D6643: Add return typehint support for PHP language.

This seems also OK

Jul 12 2017, 9:55 PM · KDevelop
zhigalin requested changes to D6643: Add return typehint support for PHP language.

This one conflicts with D6645 on parser/test/lexertest.h and parser/test/lexertest.cpp.
Change either this one or D6645 so they can apply cleanly.
Thanks for your effort!

Jul 12 2017, 4:04 PM · KDevelop
zhigalin accepted D6645: Add spaceship and null coalesce operators to PHP language support.

This one also looks good

Jul 12 2017, 3:39 PM · KDevelop
zhigalin accepted D6644: Better support iterable typehint in PHP language.

Looks good to me

Jul 12 2017, 1:13 PM · KDevelop

Jul 11 2017

zhigalin committed R52:7a6c82990908: Add more typehints to arguments in PHP (authored by mtijink).
Add more typehints to arguments in PHP
Jul 11 2017, 4:20 PM
zhigalin closed D6342: Add more typehints to arguments in PHP by committing R52:7a6c82990908: Add more typehints to arguments in PHP (authored by mtijink).
Jul 11 2017, 4:20 PM · KDevelop

Jun 18 2017

zhigalin accepted D6256: Support for variadic functions in documentation popup..

Looks good

Jun 18 2017, 1:13 PM

Jun 12 2017

zhigalin committed R216:173d46068f73: HTML syntax file version update (authored by zhigalin).
HTML syntax file version update
Jun 12 2017, 6:45 AM

Jun 10 2017

zhigalin committed R216:4f0fd13c3c47: Angular modifiers in HTML attributes added (authored by zhigalin).
Angular modifiers in HTML attributes added
Jun 10 2017, 12:18 PM
zhigalin closed D6121: Angular modifiers in HTML attributes added by committing R216:4f0fd13c3c47: Angular modifiers in HTML attributes added.
Jun 10 2017, 12:18 PM · Frameworks
zhigalin updated the diff for D6121: Angular modifiers in HTML attributes added.

Added test

Jun 10 2017, 11:49 AM · Frameworks

Jun 9 2017

zhigalin added a comment to D6121: Angular modifiers in HTML attributes added.

Going to commit it tomorrow.
Objections?

Jun 9 2017, 11:14 AM · Frameworks

Jun 7 2017

zhigalin updated subscribers of D6121: Angular modifiers in HTML attributes added.
Jun 7 2017, 6:38 AM · Frameworks

Jun 6 2017

zhigalin updated subscribers of D6121: Angular modifiers in HTML attributes added.
Jun 6 2017, 5:05 PM · Frameworks
zhigalin added reviewers for D6121: Angular modifiers in HTML attributes added: Kate, KTextEditor.
Jun 6 2017, 4:51 PM · Frameworks
zhigalin created D6121: Angular modifiers in HTML attributes added.
Jun 6 2017, 4:50 PM · Frameworks

Jun 3 2017

zhigalin committed R216:e1b0b42c19be: Bug 376979 - angle brackets in doxygen comments break syntax highlighting (authored by jonathan poelen <jo.link.noir@gmail.com>).
Bug 376979 - angle brackets in doxygen comments break syntax highlighting
Jun 3 2017, 12:20 PM
zhigalin committed R68:f6125085a563: CMakeConfig ported for KF5 (authored by zhigalin).
CMakeConfig ported for KF5
Jun 3 2017, 9:45 AM

Jun 1 2017

zhigalin committed R52:64c99f807abb: Fix compilation (authored by zhigalin).
Fix compilation
Jun 1 2017, 4:41 PM

May 15 2017

zhigalin added a comment to D5754: Make it possible to open directories from the command line.
In D5754#109711, @apol wrote:

So, what about open!
?

True, my apologies, completely forgot. Where do you want the documentation exactly?

May 15 2017, 11:13 AM
zhigalin added a comment to D5754: Make it possible to open directories from the command line.

So, what about open!
?

May 15 2017, 10:51 AM

May 8 2017

zhigalin added a comment to D5754: Make it possible to open directories from the command line.

Please add documentation to open! command

May 8 2017, 6:44 AM
zhigalin added a comment to D5122: Allow users to install via a custom root installation command.

Added a comment explaining the need of "if(suCommandIsDigit)" block.

May 8 2017, 6:42 AM · KDevelop

May 7 2017

zhigalin committed R32:5130c350f091: SVN_SILENT Added a clarifying comment (authored by zhigalin).
SVN_SILENT Added a clarifying comment
May 7 2017, 7:54 PM
zhigalin added a comment to D5122: Allow users to install via a custom root installation command.
  • When you edit an UI file, make sure not to forget to increase it's version

This is a valid comment for kxmlgui rc files, but not for Qt ui files :) The version attribute of the <ui> rather specifies the version of the schema used, not of the content.

May 7 2017, 1:11 PM · KDevelop
zhigalin committed R32:6b4e24ea1872: GIT_SILENT Revert unneeded change in previous commit (authored by zhigalin).
GIT_SILENT Revert unneeded change in previous commit
May 7 2017, 1:00 PM
zhigalin committed R32:80e3aaa1d63d: Allow users to install via a custom root installation command (authored by geetamc).
Allow users to install via a custom root installation command
May 7 2017, 12:36 PM
zhigalin closed D5122: Allow users to install via a custom root installation command by committing R32:80e3aaa1d63d: Allow users to install via a custom root installation command (authored by geetamc).
May 7 2017, 12:36 PM · KDevelop
zhigalin accepted D5122: Allow users to install via a custom root installation command.

Hello and thanks for your effort.
Just a few considerations:

May 7 2017, 12:36 PM · KDevelop

May 6 2017

zhigalin committed R33:aa56f1bfaa23: Use https://www.google.com instead of http://www.google.de in google selection… (authored by geetamc).
Use https://www.google.com instead of http://www.google.de in google selection…
May 6 2017, 5:14 PM
zhigalin closed D5719: Use https://www.google.com instead of http://www.google.de in google selection external script by committing R33:aa56f1bfaa23: Use https://www.google.com instead of http://www.google.de in google selection… (authored by geetamc).
May 6 2017, 5:14 PM

May 5 2017

zhigalin committed R33:4a96a875c97f: Added some alt-shortcuts for context menu in ProjectManagerView (authored by zhigalin).
Added some alt-shortcuts for context menu in ProjectManagerView
May 5 2017, 10:57 AM
zhigalin committed R33:a8f3ba3d6c62: Added some alt-shortcuts for context menu in ProjectManagerView (authored by zhigalin).
Added some alt-shortcuts for context menu in ProjectManagerView
May 5 2017, 10:56 AM

Apr 28 2017

zhigalin added a comment to D4686: Change the Analyzers mnemonic to Z.

Ping

Apr 28 2017, 7:28 AM

Apr 6 2017

zhigalin committed R67:cda1e57436c4: Adapt to platform changes (authored by zhigalin).
Adapt to platform changes
Apr 6 2017, 12:54 AM

Mar 7 2017

zhigalin accepted D4095: Refactor to embrace a cmake server import backend.
Mar 7 2017, 11:44 AM · KDevelop
zhigalin committed R67:fbd26fbea39b: SVN_SILENT get rid of a pesky warning (authored by zhigalin).
SVN_SILENT get rid of a pesky warning
Mar 7 2017, 2:03 AM

Mar 6 2017

zhigalin accepted D4902: Support of Class::{expr}() syntax from Php 5.4.
Mar 6 2017, 11:09 PM · KDevelop
zhigalin reopened D4095: Refactor to embrace a cmake server import backend.
Mar 6 2017, 7:54 PM · KDevelop

Mar 1 2017

zhigalin committed R52:1f15b3b33a8b: support for $this as an array when implementing ArrayAccess (authored by shashwatdixit).
support for $this as an array when implementing ArrayAccess
Mar 1 2017, 10:53 AM
zhigalin closed D4776: support for $this as an array when implementing ArrayAccess by committing R52:1f15b3b33a8b: support for $this as an array when implementing ArrayAccess (authored by shashwatdixit).
Mar 1 2017, 10:53 AM · KDevelop
zhigalin added inline comments to D4776: support for $this as an array when implementing ArrayAccess.
Mar 1 2017, 10:12 AM · KDevelop

Feb 28 2017

zhigalin added a comment to D4776: support for $this as an array when implementing ArrayAccess.

Thanks for your work, going to commit it

Feb 28 2017, 10:53 PM · KDevelop
zhigalin added inline comments to D4776: support for $this as an array when implementing ArrayAccess.
Feb 28 2017, 10:19 PM · KDevelop
zhigalin added a comment to D4776: support for $this as an array when implementing ArrayAccess.

Rest LGTM

Feb 28 2017, 7:25 PM · KDevelop
zhigalin accepted D4776: support for $this as an array when implementing ArrayAccess.
Feb 28 2017, 8:46 AM · KDevelop

Feb 27 2017

zhigalin committed R185:4dad4ec75ad0: Adapt to API change: EnvironmentGroupList -> EnvironmentProfileList (authored by zhigalin).
Adapt to API change: EnvironmentGroupList -> EnvironmentProfileList
Feb 27 2017, 7:06 PM
zhigalin closed D4822: Adapt to API change: EnvironmentGroupList -> EnvironmentProfileList by committing R185:4dad4ec75ad0: Adapt to API change: EnvironmentGroupList -> EnvironmentProfileList.
Feb 27 2017, 7:06 PM
zhigalin updated the diff for D4822: Adapt to API change: EnvironmentGroupList -> EnvironmentProfileList.

Fixed environmentProfileEntry

Feb 27 2017, 4:49 PM
zhigalin created D4822: Adapt to API change: EnvironmentGroupList -> EnvironmentProfileList.
Feb 27 2017, 3:41 PM
zhigalin added a comment to D4686: Change the Analyzers mnemonic to Z.

Good job :)

Feb 27 2017, 9:27 AM

Feb 19 2017

zhigalin requested changes to D4490: WIP: Some KDevelop specific file templates.

Agreeing with Kevin and Sven, splitting things is easier than putting parts together...

Feb 19 2017, 12:26 PM

Dec 18 2016

zhigalin committed R67:fa02f4d142a8: Add browser selection dialog (authored by zhigalin).
Add browser selection dialog
Dec 18 2016, 3:02 PM

Jul 29 2016

zhigalin accepted D2220: Implement color scheme selection from these installed in the system using KColorSchemeManager.
In D2220#42987, @kfunk wrote:

This has been pushed, right? (cf. https://git.reviewboard.kde.org/r/127979/)

Jul 29 2016, 8:54 AM

Jul 25 2016

zhigalin added inline comments to R33:b037d5829b8a: Merging of Code refactoring branch.\n\nChanges include:\nChanged internal….
Jul 25 2016, 4:56 PM

Jul 22 2016

zhigalin added a comment to D2220: Implement color scheme selection from these installed in the system using KColorSchemeManager.

See №127979
It should be OK now

Jul 22 2016, 1:59 PM

Jul 20 2016

zhigalin added inline comments to D2220: Implement color scheme selection from these installed in the system using KColorSchemeManager.
Jul 20 2016, 11:04 PM
zhigalin added inline comments to D2220: Implement color scheme selection from these installed in the system using KColorSchemeManager.
Jul 20 2016, 10:26 PM

Oct 25 2015

zhigalin added a comment to D429: Make kdev-executebrowser work with KDevelop 4.7.
In D429#8741, @mwolff wrote:

lgtm. Are you maybe interested in maintaining this plugin? Porting it to KDevelop 5 and having a release for that would be awesome, I think.

Oct 25 2015, 7:09 PM · KDevelop

Oct 18 2015

zhigalin updated D429: Make kdev-executebrowser work with KDevelop 4.7.
Oct 18 2015, 1:12 PM · KDevelop
zhigalin retitled D429: Make kdev-executebrowser work with KDevelop 4.7 from to Make kdev-executebrowser work with KDevelop 4.7.
Oct 18 2015, 1:11 PM · KDevelop
zhigalin added a member for KDevelop: zhigalin.
Oct 18 2015, 12:32 PM