Make it possible to open directories from the command line
ClosedPublic

Authored by apol on May 7 2017, 11:04 PM.

Details

Summary

When using the terminal, it's sometimes useful to open the project we're in
with KDevelop. Running kdevelop . would do this in this case.
If kdevelop isn't running then it uses a fresh instance, if it does it tells
the ones we're using to open the project, just like for files.

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.May 7 2017, 11:04 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptMay 7 2017, 11:04 PM

Please add documentation to open! command

LGTM to me in general.

That's something @cullmann wanted to have for KDevelop, btw. Maybe he's interested in testing? :)

app/main.cpp
139

Consistency: info

140

Style: for (const auto& info : ...)

500–505

uinfo -> urlInfo or info

765

Style & naming: for (const auto& initialDirectory : ...

app/urlinfo.h
91

Rather: QFileInfo(...).isDir()? More lightweight I think.

I should, but ATM I have not even build all things here ;=) But ++ for the idea ;)
For kate, we do even lookup if there is some file in the current path if we start from a console, but perhaps that would be too much auto-magic for the kdevelop use-case.

mwolff accepted this revision.May 14 2017, 10:24 AM
mwolff added a subscriber: mwolff.

please fix what kfunk pointed out, but otherwise this lgtm too

This revision is now accepted and ready to land.May 14 2017, 10:24 AM
apol marked 4 inline comments as done.May 15 2017, 9:40 AM
apol added inline comments.
app/urlinfo.h
91

If you say so... :)

This revision was automatically updated to reflect the committed changes.
apol marked an inline comment as done.

So, what about open!
?

apol added a comment.May 15 2017, 11:03 AM

So, what about open!
?

True, my apologies, completely forgot. Where do you want the documentation exactly?

In D5754#109711, @apol wrote:

So, what about open!
?

True, my apologies, completely forgot. Where do you want the documentation exactly?

Inside help! open I think

apol added a comment.May 18 2017, 10:54 PM
In D5754#109711, @apol wrote:

So, what about open!
?

True, my apologies, completely forgot. Where do you want the documentation exactly?

Inside help! open I think

Hi, I just checked and the behavior there didn't change.