Differential D4822

Adapt to API change: EnvironmentGroupList -> EnvironmentProfileList
ClosedPublic
Actions

Authored by zhigalin on Feb 27 2017, 3:41 PM.

Details

Reviewers
patrickelectric
kfunk
Group Reviewers
KDevelop
Commits
R185:4dad4ec75ad0: Adapt to API change: EnvironmentGroupList -> EnvironmentProfileList

Diff Detail

Repository
R185 KDevelop Plugin: Embedded Platforms
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zhigalin created this revision.Feb 27 2017, 3:41 PM
kfunk accepted this revision.Feb 27 2017, 3:55 PM
kfunk added a subscriber: kfunk.

Rest LGTM

launcher/executeplugin.cpp
54

The value stayed at QStringLiteral("EnvironmentGroup"); in kdevplatform. Please do the same here.

This revision is now accepted and ready to land.Feb 27 2017, 3:55 PM
kfunk added a subscriber: patrickelectric.Feb 27 2017, 4:02 PM

Unrelated to this patch:

@patrickelectric : What's the relation of ExecutePlugin in kdev-embedded & ExecutePlugin kdevplatform? Isn't there more code we could share?

zhigalin updated this revision to Diff 11907.Feb 27 2017, 4:49 PM

Fixed environmentProfileEntry

patrickelectric accepted this revision.Feb 27 2017, 4:53 PM
patrickelectric added a comment.Feb 27 2017, 4:58 PM

@kfunk: Yes, I will make a better integration in the next patchs with kdevplatform, right now I am in the last month of my thesis.
@zhigalin++.

Closed by commit R185:4dad4ec75ad0: Adapt to API change: EnvironmentGroupList -> EnvironmentProfileList (authored by zhigalin). · Explain WhyFeb 27 2017, 7:06 PM
This revision was automatically updated to reflect the committed changes.
zhigalin marked an inline comment as done.

Revision Contents
Changeset List

Diff 11915

View Options

launcher/embeddedlauncher.cpp

Loading...
View Options

launcher/executeplugin.h

Loading...
View Options

launcher/executeplugin.cpp

Loading...
View Options

launcher/launcherjob.cpp

Loading...