Details
- Reviewers
kfunk - Group Reviewers
KDevelop - Commits
- R32:a733fc6b2881: Change the Analyzers mnemonic to Z
Diff Detail
- Repository
- R32 KDevelop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
The "Analyze" now menu used not only by cppcheck, but also by valgrind, clang-tydy, and vera++ plugins. I think it's not good idea to mix code actions like declaration rename and, for example, valgrind memory checkers.
If anything, the contents would be better suited to the Run menu (e.g. Valgrind and Cppcheck are roughly equivalent to "Debug Launch" and "Run all tests" respectively).
But this seems a bad idea to me, there's a huge number of analysis tools and the number integrated will hopefully grow over time. For a brand-new interface, Anton's already got a fair number of plugins in.
In fact, why shouldn't the contents of Code (even fewer, infrequently-usedactions) just be under Tools?
I wouldn't think it's a good idea to mix static analyzers and runtime either... if the application needs to be executed, it should be under the Run menu (if not a launcher itself).
| app/kdevelopui.rc | ||
|---|---|---|
| 53 | Bin to Alt+z instead? I don't think this is used. | |
I wouldn't think it's a good idea to mix static analyzers and runtime either... if the application needs to be executed, it should be under the Run menu (if not a launcher itself).
I agree with you about mixing static analyzers and runtime checkers. But in the future we will have (I hope) more checkers and if we will place them in different menus it can be confused approach for user which will find them in different places. After adding new checkers we can reorganize "Analyze" menu for more consistent view and, for example, add separate submenu for static analyze tools.
That diff looks broken, but I think it does the right thing. You've just changed the shortcut key now, right?
