Angular modifiers in HTML attributes added
ClosedPublic
Actions

Authored by zhigalin on Jun 6 2017, 4:50 PM.

Details

Reviewers

Group Reviewers

Kate
KTextEditor

Commits

R216:4f0fd13c3c47: Angular modifiers in HTML attributes added

Summary

Angular uses special characters in HTML atributes
This disables the error highlighting for []()*# in HTML tag attributes

Test Plan

<div class="field">
  <label *for="title()">Title:</label>
  <input (name)="title">
</div>
<div class="field">
  <label #for="link">Link:</label>
  <input [name]="link">
</div>

Diff Detail

Repository

R216 Syntax Highlighting

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

zhigalin created this revision.Jun 6 2017, 4:50 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptJun 6 2017, 4:50 PM

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

zhigalin added reviewers: Kate, KTextEditor.Jun 6 2017, 4:51 PM

zhigalin edited subscribers, added: Kate, KTextEditor; removed: Frameworks.Jun 6 2017, 5:05 PM

kfunk added a reviewer: kwrite-devel.Jun 7 2017, 6:31 AM

zhigalin added a subscriber: kwrite-devel.Jun 7 2017, 6:38 AM

Going to commit it tomorrow.
Objections?

Perhaps add Volker, too.
Actually, an extended unit test would be nice. Otherwise I am fine with that.

Added test

Closed by commit R216:4f0fd13c3c47: Angular modifiers in HTML attributes added (authored by zhigalin). · Explain WhyJun 10 2017, 12:18 PM

This revision was automatically updated to reflect the committed changes.

Please also increase the version number, otherwise your update will not get picked up by our scripts on kate-editor.org. Since you already committed this change, please do so in another commit.

data/syntax/html.xml
8	You have to increase the version number to version="5"

Revision Contents
Changeset List

			Path	Packages
M			autotests/folding/test.htm.fold (4 lines)
M			autotests/html/test.htm.html (4 lines)
M			autotests/input/test.htm (4 lines)
M			autotests/reference/test.htm.ref (4 lines)
M			data/syntax/html.xml (9 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	15225	6891e5a		Jun 6 2017, 4:50 PM	★	★
Diff 2	15322	6891e5a	Added test	Jun 10 2017, 11:49 AM	★	★
Diff 3	15323	8359ed4	R216:4f0fd13c3c47f64762292ec223fd4055f3292337	Jun 10 2017, 12:17 PM	★	★