geetamc (Geetam Chawla)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Mar 21 2017, 2:54 PM (118 w, 53 m)
Availability
Available

Recent Activity

Nov 16 2017

geetamc added a comment to D8831: gcclikecompiler: Fix execution of compiler qprocess under windows.
In D8831#168209, @kfunk wrote:

Thanks a lot for these patches!

Nov 16 2017, 4:32 AM

Nov 15 2017

geetamc added a comment to D8831: gcclikecompiler: Fix execution of compiler qprocess under windows.

So the actual error is: gcc.exe: error: \\.\NUL: Invalid argument

Nov 15 2017, 9:35 PM
geetamc added a comment to D8831: gcclikecompiler: Fix execution of compiler qprocess under windows.

I understand what the patch does, but can you explain why this fixes your issue?

Nov 15 2017, 9:06 PM
geetamc created D8831: gcclikecompiler: Fix execution of compiler qprocess under windows.
Nov 15 2017, 8:04 PM

Nov 14 2017

geetamc updated the diff for D8805: fix "none" being set as default compiler on windows.
  • remove unnecessary ifdef block
Nov 14 2017, 11:14 AM

Nov 13 2017

geetamc created D8805: fix "none" being set as default compiler on windows.
Nov 13 2017, 11:01 PM

Nov 10 2017

geetamc closed D8727: fix templates not working on windows.

Commit: https://phabricator.kde.org/R32:86bbc9ffe63b

Nov 10 2017, 4:59 PM

Nov 8 2017

geetamc created D8727: fix templates not working on windows.
Nov 8 2017, 5:26 PM

Oct 28 2017

geetamc added a comment to D8523: Use native separators while copying filename to clipboard.
In D8523#161270, @kfunk wrote:

@geetamc Note: Please fixup your user name to in Git (git config user.name).

I needed to amend your patch in order to fix this issue:

remote: Audit failure - Commit 55f2f00c8376837c9084b36413ae45b3f5652569 - Non-full name: Geetam
remote: FATAL: VREF/kde-update-checks: helper program exit status 256
remote: Push declined - commits failed audit

Thanks for the patch!

Oct 28 2017, 6:12 PM
geetamc updated the diff for D8523: Use native separators while copying filename to clipboard.
  • fixed weird indentation
Oct 28 2017, 11:00 AM

Oct 27 2017

geetamc added a reviewer for D8523: Use native separators while copying filename to clipboard: KDevelop.
Oct 27 2017, 2:23 PM
geetamc created D8523: Use native separators while copying filename to clipboard.
Oct 27 2017, 2:19 PM

Jul 25 2017

geetamc created D6901: Fix warning -Wimplicit-fallthrough.
Jul 25 2017, 6:12 PM

Jul 13 2017

geetamc added a comment to D6689: CMake code completion: Add missing chars to be escaped.
In D6689#125180, @kfunk wrote:

Thanks for the patches, Geetam.

I encourage you to start using Arcanist to upload the patches as that will a) make reviewing the patches easier (because there's "context" in the diff view), b) add proper author information to the Phab Diff.

Please see: https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist

Jul 13 2017, 8:32 PM
geetamc created D6689: CMake code completion: Add missing chars to be escaped.
Jul 13 2017, 5:36 PM

Jul 11 2017

geetamc created D6638: [Windows] Add MinGW generator to global CMake settings page.
Jul 11 2017, 10:35 PM

Jul 4 2017

geetamc updated the test plan for D6505: Fix external launch of executables with spaces in paths[windows].
Jul 4 2017, 3:12 PM
geetamc updated the summary of D6505: Fix external launch of executables with spaces in paths[windows].
Jul 4 2017, 3:11 PM
geetamc created D6505: Fix external launch of executables with spaces in paths[windows].
Jul 4 2017, 3:10 PM

May 16 2017

geetamc updated the summary of D5777: Fix splitting of root installation command, add default value for the same in .kcfg.
May 16 2017, 9:04 PM
geetamc added a comment to D5777: Fix splitting of root installation command, add default value for the same in .kcfg.
In D5777#109999, @apol wrote:

I don't really understand the patch, there's the bit there so that if (cmd.isEmpty) kdesu -t. What are you trying to fix?

May 16 2017, 2:09 PM

May 8 2017

geetamc retitled D5777: Fix splitting of root installation command, add default value for the same in .kcfg from Fix check for empty su command for installing as root to Fix splitting of root installation command, add default value for the same in .kcfg.
May 8 2017, 9:40 PM
geetamc updated the diff for D5777: Fix splitting of root installation command, add default value for the same in .kcfg.

used KShell:splitArgs to split su command.

May 8 2017, 9:11 PM
geetamc updated the diff for D5777: Fix splitting of root installation command, add default value for the same in .kcfg.
May 8 2017, 8:29 PM
geetamc added a comment to D5777: Fix splitting of root installation command, add default value for the same in .kcfg.

@apol Thanks, I will surely.
But I will update the revision right now without the change as I accidentally created the diff against an older base.

May 8 2017, 8:26 PM
geetamc created D5777: Fix splitting of root installation command, add default value for the same in .kcfg.
May 8 2017, 8:07 PM
geetamc added a comment to D5122: Allow users to install via a custom root installation command.

Ignore the previous update, I am making a new review request.

May 8 2017, 7:53 PM · KDevelop
geetamc updated the diff for D5122: Allow users to install via a custom root installation command.

-Added a default value for entry "suCommand" in makebuilderconfig.kcfg
-The qstring suCommand is checked for emptiness instead of qstringlist "suCommandWithArg".
(Reason: when an empty qstring is split, the returned qstringlist.isEmpty() is False)

May 8 2017, 7:42 PM · KDevelop

May 7 2017

geetamc updated the diff for D5122: Allow users to install via a custom root installation command.

Added a comment explaining the need of "if(suCommandIsDigit)" block.

May 7 2017, 4:41 PM · KDevelop
geetamc added a comment to D5122: Allow users to install via a custom root installation command.

Hello and thanks for your effort.
Just a few considerations:

  • When you edit an UI file, make sure not to forget to increase it's version
  • You also forgot to bind kcfg_suCommand.enabled(bool) to kcfg_installAsRoot.toggled(bool)
  • You must use QStringLiteral, not just plain strings
  • Try placing less newlines around
May 7 2017, 12:40 PM · KDevelop

May 5 2017

geetamc added a comment to D5719: Use https://www.google.com instead of http://www.google.de in google selection external script.

Yes, makes sense. Do you have commit access?

May 5 2017, 5:34 PM
geetamc created D5719: Use https://www.google.com instead of http://www.google.de in google selection external script.
May 5 2017, 4:35 PM

Apr 27 2017

hectordavid awarded D5122: Allow users to install via a custom root installation command a Burninate token.
Apr 27 2017, 3:20 PM · KDevelop

Mar 31 2017

geetamc added a comment to D5122: Allow users to install via a custom root installation command.

Few suggestions related to the commit message: it should follow the guidelines for git message.
So the first line should be a short summary of the change (no need to mention the bug), "allow users to install via custom command" or something like that.

The bug should report in one of the other line not as link but with

BUG: nnnnnn

Mar 31 2017, 3:53 PM · KDevelop
geetamc retitled D5122: Allow users to install via a custom root installation command from This patch fixes bug 374144, Basically it allows users to install via a custom root installation command to Allow users to install via a custom root installation command.
Mar 31 2017, 3:52 PM · KDevelop

Mar 30 2017

geetamc updated the diff for D5122: Allow users to install via a custom root installation command.

If entry "Su Command" is an integer in range [0, 3) (which can be a scenario when user, for the first time opens his/her project in the updated kdevelop)
then suCommand is set appropriately and is written to entry "Su Command" .

Mar 30 2017, 7:10 PM · KDevelop
geetamc added a comment to D5122: Allow users to install via a custom root installation command.

Alright so I feel, regarding my last comment, Having an extra variable suCommandStr and an extra readEntry() is unnecessary, In the switch block I will simply assign suCommand the appropriate value, and write suCommand to the "Su Command" Entry.
Also I feel updating the diff will give you guys a better Idea so I will do the same in a while.

Mar 30 2017, 6:56 PM · KDevelop
geetamc added a comment to D5122: Allow users to install via a custom root installation command.

@ematirov Thank you for reviewing! Have a look at the inline comment.

Mar 30 2017, 6:36 PM · KDevelop

Mar 22 2017

geetamc updated the summary of D5122: Allow users to install via a custom root installation command.
Mar 22 2017, 12:20 PM · KDevelop
geetamc updated the diff for D5122: Allow users to install via a custom root installation command.

arguments such as "-t" now pass correctly.

Mar 22 2017, 12:18 PM · KDevelop
geetamc updated the summary of D5122: Allow users to install via a custom root installation command.
Mar 22 2017, 11:54 AM · KDevelop
geetamc updated the diff for D5122: Allow users to install via a custom root installation command.

I believe that having combo box editable is a cleaner way to solve the same problem, I will revert the changes if reviewers feel that having a plain text edit and an entry for Custom Command in combo box is more appropriate.

Mar 22 2017, 11:45 AM · KDevelop

Mar 21 2017

geetamc added a comment to D5122: Allow users to install via a custom root installation command.

I forgot to implement a feature mentioned by brauch, will do it tomorrow.

Mar 21 2017, 9:24 PM · KDevelop
geetamc added a comment to D5122: Allow users to install via a custom root installation command.

Since I am new to submitting patches would you please tell me when updating diff should I upload the diff representing the latest changes or one that represents the whole patch?

Mar 21 2017, 9:00 PM · KDevelop
geetamc added a comment to D5122: Allow users to install via a custom root installation command.

The build was successful, the patch now works as intended please let me know if I missed something.

Mar 21 2017, 7:36 PM · KDevelop
geetamc added a comment to D5122: Allow users to install via a custom root installation command.
In D5122#96551, @kfunk wrote:

My build fails right now after a git pull

kdevelop/languages/clang/duchain/macronavigationcontext.cpp:58:28: error: ‘prefix’ was not declared in this scope

You need to git pull in kdevplatform and recompile/reinstall.

I have made most of the changes also I have an exam tomorrow so I will definitely update the diff by tomorrow.

Thank you both brauch and kfunk for reviewing.

Mar 21 2017, 7:06 PM · KDevelop
geetamc updated the diff for D5122: Allow users to install via a custom root installation command.

-Corrected the casing of "Custom Command"
-Appended ':' to the label
-Label and text edit of Custom Command are now disabled by default
-removed unnecessary 'else'

Mar 21 2017, 6:46 PM · KDevelop
geetamc added a comment to D5122: Allow users to install via a custom root installation command.

My build fails right now after a git pull

Mar 21 2017, 6:22 PM · KDevelop
geetamc added a comment to D5122: Allow users to install via a custom root installation command.
In D5122#96534, @brauch wrote:

Can you make the line edit disabled when something else than "custom command" is selected?
Otherwise, LGTM, thanks for the patch!

Mar 21 2017, 6:09 PM · KDevelop
geetamc updated the summary of D5122: Allow users to install via a custom root installation command.
Mar 21 2017, 5:35 PM · KDevelop
geetamc created D5122: Allow users to install via a custom root installation command.
Mar 21 2017, 5:32 PM · KDevelop
geetamc added a member for KDevelop: geetamc.
Mar 21 2017, 3:26 PM
geetamc added a watcher for KDevelop: geetamc.
Mar 21 2017, 3:16 PM