- User Since
- Mar 21 2017, 2:54 PM (108 w, 5 d)
Nov 16 2017
Nov 15 2017
So the actual error is: gcc.exe: error: \\.\NUL: Invalid argument
Nov 14 2017
- remove unnecessary ifdef block
Nov 13 2017
Nov 10 2017
Nov 8 2017
Oct 28 2017
- fixed weird indentation
Oct 27 2017
Jul 25 2017
Jul 13 2017
Jul 11 2017
Jul 4 2017
May 16 2017
May 8 2017
used KShell:splitArgs to split su command.
@apol Thanks, I will surely.
But I will update the revision right now without the change as I accidentally created the diff against an older base.
Ignore the previous update, I am making a new review request.
-Added a default value for entry "suCommand" in makebuilderconfig.kcfg
-The qstring suCommand is checked for emptiness instead of qstringlist "suCommandWithArg".
(Reason: when an empty qstring is split, the returned qstringlist.isEmpty() is False)
May 7 2017
Added a comment explaining the need of "if(suCommandIsDigit)" block.
May 5 2017
Apr 27 2017
Mar 31 2017
Mar 30 2017
If entry "Su Command" is an integer in range [0, 3) (which can be a scenario when user, for the first time opens his/her project in the updated kdevelop)
then suCommand is set appropriately and is written to entry "Su Command" .
Alright so I feel, regarding my last comment, Having an extra variable suCommandStr and an extra readEntry() is unnecessary, In the switch block I will simply assign suCommand the appropriate value, and write suCommand to the "Su Command" Entry.
Also I feel updating the diff will give you guys a better Idea so I will do the same in a while.
@ematirov Thank you for reviewing! Have a look at the inline comment.
Mar 22 2017
arguments such as "-t" now pass correctly.
I believe that having combo box editable is a cleaner way to solve the same problem, I will revert the changes if reviewers feel that having a plain text edit and an entry for Custom Command in combo box is more appropriate.
Mar 21 2017
I forgot to implement a feature mentioned by brauch, will do it tomorrow.
Since I am new to submitting patches would you please tell me when updating diff should I upload the diff representing the latest changes or one that represents the whole patch?
The build was successful, the patch now works as intended please let me know if I missed something.
-Corrected the casing of "Custom Command"
-Appended ':' to the label
-Label and text edit of Custom Command are now disabled by default
-removed unnecessary 'else'
My build fails right now after a git pull