I still think 3 horizontal dots is the best form of half checked state proposed here.

We should probably keep the show preview button unless we want to enable previews by default.

Make sure the default layout doesn't look lopsided when the application menu is enabled instead of the control button.

In T10891#194989, @lavender wrote:

The first highlighted pushbutton (where the cursor is) is less visible in your version than noah's due to the contrast.

+1, seems like a good idea.

So what do you think about these highlight/selection/hover/focus colors? I chose them by taking Plasma Blue (#3daee9) from the KDE HIG and adjusting the brightness with HSLuv.org. The selection background color is 1/2 the brightness and the hover background is 2/3. I don't really know how to pick colors, so I'm taking a somewhat conservative approach where new colors are at least somewhat based on existing ones.

In T10891#194749, @onvitaik wrote:

Here's another set of dark theme mockups (and some miscellaneous modifications to tabs, sidebars, title bars) :

And the original screenshots I used as a base, for comparison:

@broulik With D23033, the notification-disabled element will be unused. Do you still require changes to this patch?

• Don't change default icon

In D23019#508599, @broulik wrote:

You can't repurpose icon ids for different meanings:

This is what the "no notifications" case looks like now with the old applet.

• Hide label by default

In D23019#508581, @broulik wrote:

Screenshots, please.
The question is what about the transition when this is released in Frameworks but the Plasma version with the change isn't yet.

• Undo DND icon change

I can confirm that this fixes the bug. Thanks!

Ah, thanks.

This stops Plasmashell from segfaulting, but now it exits (code 1) with this message every other time plasmashell --replace & is run:

In D22874#506843, @broulik wrote:

I get the plasmashell --replace not working correctly occasionally. I don't think this is related to any of this.

After this patch, when I run plasmashell --replace & 3 times in a row, the following happens: