BUG: 384015
Details
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Screenshots, please.
The question is what about the transition when this is released in Frameworks but the Plasma version with the change isn't yet.
You can't repurpose icon ids for different meanings:
This is what the "no notifications" case looks like now with the old applet.
I didn't repurpose the icon, the old applet just uses a weird default icon (notification-disabled for a non-disabled state). I can wait until Plasma 5.17 to land this patch.
I think I approve of the end goal, but it seems like this needs a change in the notifications widget rather than just changing the icon itself.
Edit: Never mind, I'm a dope
If you change the icon that it uses in the stable branch, then this would probably be just fine IMO.
Never mind, you did change it to notification-inactive in the other patch. So this is good to go IMO.
As for landing it, we have two options to make sure that rolling release distro users don't see their notification icon change to the one with the red line through it:
- Land this patch for 5.63 (the Frameworks release aligned with Plasma 5.17)
- Change the inactive applet to use the notification-inactive icon in another patch and land that on the stable branch, then land this