[lockscreen] Fit album art to defined geometry
ClosedPublic

Authored by filipf on Aug 9 2019, 11:08 PM.

Details

Summary

No one likes stretched images.

Test Plan

Before:

After:

Square album art is still a square.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Aug 9 2019, 11:08 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 9 2019, 11:08 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Aug 9 2019, 11:08 PM
filipf edited the test plan for this revision. (Show Details)Aug 9 2019, 11:09 PM
filipf added reviewers: Plasma, VDG, ngraham.
ndavis added a subscriber: ndavis.Aug 10 2019, 1:55 AM

+1, seems like a good idea.

The small image looks weird too, but I suppose it's better to present weird images in their true form than to make them look even weirder by stretching them.

ngraham accepted this revision.Aug 10 2019, 3:28 AM

+1, seems like a good idea.

The small image looks weird too, but I suppose it's better to present weird images in their true form than to make them look even weirder by stretching them.

Exactly.

Please land on the stable branch!

This revision is now accepted and ready to land.Aug 10 2019, 3:28 AM
This revision was automatically updated to reflect the committed changes.