[notifications] Change default icon to notification-inactive
ClosedPublic

Authored by ndavis on Aug 8 2019, 10:15 PM.

Details

Summary

Currently, it uses notification-disabled for a non-disabled state.

Test Plan

Breeze:

Breeze (with D23019):

Air:

Oxygen:

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ndavis created this revision.Aug 8 2019, 10:15 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 8 2019, 10:15 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ndavis requested review of this revision.Aug 8 2019, 10:15 PM
ndavis edited the test plan for this revision. (Show Details)
ndavis edited the summary of this revision. (Show Details)Aug 8 2019, 10:18 PM
ndavis edited the test plan for this revision. (Show Details)
ngraham accepted this revision.Aug 8 2019, 11:22 PM
ngraham added a subscriber: ngraham.

This is for sure the more appropriate icon IMO as 1) it's what we used for notifications in all other contexts and 2) it's the monochrome version of the colorful bell icon used in the tooltip.

This should be landed on the stable branch in support of being able to do D23019.

This revision is now accepted and ready to land.Aug 8 2019, 11:22 PM
This revision was automatically updated to reflect the committed changes.