I agree.

Using Kubuntu 16.04: The code gets compiled and the default delete mode is "Move to trash", that's good at least for new users. Thanks, Alex! :-)

Using Kubuntu 16.04: Esc now does not close Lister if the search bar was enabled :-). If the search bar was not enabled, Esc closes Lister, etc. :-) Thanks, Martin!

Using Kubuntu 16.04: Lister now is able to scroll and zoom in cases where Lister wasn't able :-)

I agree, too, and maybe with those VFS improvements... important bugs like

A problem renaming a file that is inside an archive
https://bugs.kde.org/show_bug.cgi?id=350028

would be solved.

Various fixes and improvents, most important:

Good! "Compress" and "Extract" submenus work here, too!

Synchronizer worked correctly in all the tests :-) , thank you.

Using Kubuntu 16.04 the code of Alex seems to be compiled and executed correctly :-) . Thanks!

If somebody really needs different behaviour I can add another config option.

The code gets compiled using Kubuntu 16.04 and seems to work correctly :-)

The code gets compiled using Kubuntu 16.04 and seems to work correctly :-)

The code can be compiled using Kubuntu 16.04, although I don't have a 5-buttons mouse to test it :-)

Some weird folders are now browsable using Krusader! :-)

The code gets compiled using Kubuntu 16.04 and seems to work correctly :-)

It compiles and works here :-) .

If it can be helpful to understand the changes: I attach a screenshot about:

• The button that was added.
• The splitter that was talked about.
• The panel popup that was talked about.

And thanks for testing again!

I'm going to close this because it looks like it's done. Anyone can feel free to reopen it if it's necessary :-)

I'm going to close this because it looks like it's done. Anyone can feel free to reopen it if it's necessary :-)

To perform some tests today I also deleted the delete proc; line, I also added

qDebug() << "======> A new KrActionProc was made." << endl;

to

KrActionProc::KrActionProc(KrActionBase* action)

and I also added

qDebug() << "======> A KrActionProc was deleted." << endl;

to

KrActionProc::~KrActionProc()

I really like it that way, but there are many possibilities. What do you think?

Thanks for the improvements!

Additional information:

There is a big amount of good work there, Alex!

Fixing various coding problems found with static code analysis tools.

Thank you all!

Thanks, Alex!

Thank you for your improvements, Martin!

Thanks, Martin, I've tried your changes in Kubuntu 16.04 and Krusader has been compiled successfully even not having KF 5.23. Several operations with archives (opening archives, deleting files, adding files to archives) have worked correctly, I've tried to rename a file inside an archive and it hasn't work, as it happened before the patch.

Thanks, Martin! Although using the last KF5 is out of my reach, the changes seem to be good.

Minor simplifications, solutions and clarifications were made.

It it can be useful to anyone, in order to help to compare traces obtained from /tmp/krdebug:

Hi!
There are good news about this. David Faure wrote that if krarc is preferred, then to find if krarc is available, it can be used: KProtocolInfo::isKnownProtocol("krarc")

If user does not have preferred mimetypes set in his/her Krusader -> Protocols section, there would still be a preference of krarc:/ protocol when deciding how to open an archive.

Thanks!

I've noticed that archives are sometimes opened e.g. with zip:/ and sometimes with kracr:/ protocol.

[As it was commented in https://phabricator.kde.org/D1529#28381]

If this is accepted by Krusader Krew, I'll propose it to KIO developers.

Some polishing was made, now that I've had some time.

Deduplication avoids problems like "in the end a developer will make a change in one place and will not make it in the other one", etc.

Ok!

Martin, thanks to your work this has been started and solved :-)

It worked there :-)

It worked for me, thanks. If anyone else wants to try it, in my case (in Kubuntu 16.04beta2) I had also to:

• Rename the file "uk.mo" to "krusader.mo", copy it to "/usr/share/locale/<LANGUAGE>/LC_MESSAGES/".

On a related issue, I am using some new code to perform more complete and intuitive traces of the execution of the krarc kioslave, so the traces include when the execution of a function starts, and (automatically) when it's going to finish. That is a screenshot of a comparison between two traces:

• On the left part of the screenshot it can be seen:
  • The trace of the execution of the krarc kioslave when: the D1394 patch is not applied, the "enable write support" option is disabled, the user enters a 7z file ("/home/user/compressed_file.7z") and copies one file ("é.txt") outside. Note: The name of the file of the trace is "krdebug-unpatched-noWriteSupport" in the screenshot.

Would you attach a translated file, so that we can try the change more easily?

I agree :-)

Thanks a lot for your review, Toni! Unfortunately I'm unable to replicate the issue You mentioned. I'm going
to commit the change and work on other issues in lister and we'll see if the other fixes fix (or expose more) the
problem with ctrl+shift+arrow after mouse selection.

Although trying it, in a binary file, sometimes I selected text with the mouse from bottom to top, and then I pressed Ctrl+Shift+left but the cursor went to the right, and vice versa; but anyway it happened only occasionally, maybe it's a local little problem, and anyway the work of Martin left Lister much better than it was!