Differential D1373

edit existing file instead of creating a new empty one
ClosedPublic
Actions

Authored by gengisdave on Apr 10 2016, 9:26 AM.

Details

Reviewers
asensi
martinkostolny
Group Reviewers
Krusader
Maniphest Tasks
T2180: New file (Shift+F4) behaviour
Summary

When the user creates a new file that already exists, krusader asks to overwrite it; it's better to open it for editing (using the same check as the standard edit).

Test Plan

I haven't tested well on remote urls (ftp etc)

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
gengisdave updated this revision to Diff 3252.Apr 10 2016, 9:26 AM
gengisdave retitled this revision from to edit existing file instead of creating a new empty one.
gengisdave updated this object.
gengisdave edited the test plan for this revision. (Show Details)
gengisdave added a reviewer: Krusader.
gengisdave added a project: Krusader.
gengisdave added a task: T2180: New file (Shift+F4) behaviour.
gengisdave added a subscriber: Krusader.
martinkostolny accepted this revision.EditedApr 10 2016, 10:55 AM
martinkostolny added a reviewer: martinkostolny.
martinkostolny added a subscriber: martinkostolny.

It works for local files. For remote locations (e.g. SFTP) it works as before. But I think I can be done in separate commit.

Thanks for the code!

This revision is now accepted and ready to land.Apr 10 2016, 10:55 AM
asensi accepted this revision.Apr 12 2016, 9:44 PM
asensi added a reviewer: asensi.
asensi added a subscriber: asensi.

I agree :-)

gengisdave closed this revision.Jun 19 2016, 7:44 PM

committed

Revision Contents
Changeset List

PathPackages
Mkrusader/Panel/panelfunc.cpp (48 lines)

Diff 3252

View Options

krusader/Panel/panelfunc.cpp

Loading...