If this is accepted by Krusader Krew, I'll propose it to KIO developers.
Details
Details
- Reviewers
asensi gengisdave - Group Reviewers
Krusader - Maniphest Tasks
- T2401: Preferring krarc as a primarily chosen protocol for various archive formats
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
If this is accepted by Krusader Krew, I'll propose it to KIO developers.
It's a good idea, and KIO developers can tell later what they think.
Note: Probably KIO developers will like that for example value.at(0) is used (instead of using value(0)) because in https://doc.qt.io/qt-5/qlist.html it's written that "at() can be faster than operator[](), because it never causes a deep copy to occur".
Comment Actions
Thanks for review and the at() suggestion! I've chosen value(0) because when the list is empty, it creates empty string automatically. But I didn't know that it is always making a copy of the value. So I'll adjust the code so that there is a list size condition and at(0) call.
Comment Actions
David Faure created a useful method KProtocolInfo::archiveMimetypes("krarc") which we've used in D1528.