Set default delete mode to "Move to trash"
ClosedPublic

Authored by abika on Aug 14 2016, 12:52 PM.

Details

Summary

As already discussed

Test Plan

Removed krusaderrc config file, started krusader, checked delete mode
+ checked context menu and shortcuts

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
abika updated this revision to Diff 5909.Aug 14 2016, 12:52 PM
abika retitled this revision from to Set default delete mode to "Move to trash".
abika updated this object.
abika edited the test plan for this revision. (Show Details)
abika added a reviewer: Krusader.
gengisdave added a subscriber: gengisdave.EditedAug 14 2016, 1:11 PM

There's a shortcut missing: when you switch to recycle bin, you can't delete files with the keyboard (the popup menu shows "Move to trash" and "Delete").

SHIFT+DEL would be fine, it is mentioned in old changelogs, but it does nothing :(

Found it, I had an alternate shortcut for "Cut" that conflicts with delete. I will try some distros to see if it's a common setting or not.

This comment was removed by gengisdave.
abika added a comment.Aug 14 2016, 1:38 PM

Try with "CTRL+DEL". Using SHIFT doesn't work for me either which is strange because the code is

op()->emitDeleteFiles(e->modifiers() == Qt::ShiftModifier || e->modifiers() == Qt::ControlModifier);

in krview.cpp.

Another shortcut is F8 (without any modifier support).

abika added a comment.Aug 14 2016, 1:42 PM

Ah, now I read your post update.

Yes, you're right SHIFT+DEL is the default alternate shortcut for the "cut" operation. Looks like this is the default in KDE's "Standard keyboard shortcuts for applications".

But CTRL+DEL is fine too, isn't it?

gengisdave accepted this revision.Aug 14 2016, 1:49 PM
gengisdave added a reviewer: gengisdave.

CTRL+DEL works fine and it doesn't seems to conflicts with other actions (afaik, it is used to delete the whole next word, but we're not in an edit mode).

Dolphin can use SHIFT+DEL to delete files because it seems to ignore the alternate cut command.

This revision is now accepted and ready to land.Aug 14 2016, 1:49 PM
martinkostolny accepted this revision.Aug 14 2016, 5:27 PM
martinkostolny added a reviewer: martinkostolny.
asensi accepted this revision.Aug 14 2016, 8:25 PM
asensi added a reviewer: asensi.
asensi added a subscriber: asensi.

Using Kubuntu 16.04: The code gets compiled and the default delete mode is "Move to trash", that's good at least for new users. Thanks, Alex! :-)

Closed by commit R167:004256f00ca9: Set default delete mode to "Move to trash" (authored by Alexander Bikadorov <bikaejkb@mailbox.tu-berlin.de>). · Explain WhyAug 19 2016, 7:11 PM
This revision was automatically updated to reflect the committed changes.